From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23719 invoked by alias); 5 Jan 2007 07:40:42 -0000 Received: (qmail 23702 invoked by uid 22791); 5 Jan 2007 07:40:40 -0000 X-Spam-Check-By: sourceware.org Received: from zigzag.lvk.cs.msu.su (HELO zigzag.lvk.cs.msu.su) (158.250.17.23) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 05 Jan 2007 07:40:35 +0000 Received: from Debian-exim by zigzag.lvk.cs.msu.su with spam-scanned (Exim 4.50) id 1H2jgf-00037C-Ei for gdb-patches@sources.redhat.com; Fri, 05 Jan 2007 10:40:30 +0300 Received: from localhost ([127.0.0.1] helo=ip6-localhost) by zigzag.lvk.cs.msu.su with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.50) id 1H2jgV-00036y-Hb; Fri, 05 Jan 2007 10:40:15 +0300 From: Vladimir Prus To: Nick Roberts Subject: Re: [PATCH] MI: Add value field to output of -var-create Date: Fri, 05 Jan 2007 07:40:00 -0000 User-Agent: KMail/1.9.1 Cc: gdb-patches@sources.redhat.com References: <17818.12006.696879.216415@kahikatea.snap.net.nz> <17821.35879.508258.356360@kahikatea.snap.net.nz> In-Reply-To: <17821.35879.508258.356360@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200701051040.13686.ghost@cs.msu.su> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00170.txt.bz2 On Friday 05 January 2007 02:22, Nick Roberts wrote: > > I think this is a good change in general. However, the problem is that > > a lot of tests hardcode the output from -var-create, and are broken with > > this change. I think that instead of adding more hardcoding, we'd > > need to replace all creation of varobjs with calls to mi_create_varobj. > > Would you be willing to do that? > > It seems unfortunate to me that the output from -var-create gets tested so many > times but Daniel has just said that mi_gdb_test should really should used even > if you don't care about the result. FWIW, mi_create_varobj does use mi_gdb_test. > Real tests for -var-create e.g in > mi-var-cmd.exp need to be looked at more carefully (some test when -var-create > fails) but, sure, mi_create_varobj could be used when you don't care about the > result. Good. Yes, it's unfortunate that the work on updating tests far exceeds the work to make the patch itself, but at this point we can only try to avoid this in future ;-) - Volodya