From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9933 invoked by alias); 4 Jan 2007 21:14:24 -0000 Received: (qmail 9925 invoked by uid 22791); 4 Jan 2007 21:14:24 -0000 X-Spam-Check-By: sourceware.org Received: from zigzag.lvk.cs.msu.su (HELO zigzag.lvk.cs.msu.su) (158.250.17.23) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 04 Jan 2007 21:14:19 +0000 Received: from Debian-exim by zigzag.lvk.cs.msu.su with spam-scanned (Exim 4.50) id 1H2Zuc-00070I-Vu for gdb-patches@sources.redhat.com; Fri, 05 Jan 2007 00:14:16 +0300 Received: from localhost ([127.0.0.1] helo=ip6-localhost) by zigzag.lvk.cs.msu.su with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.50) id 1H2ZuT-0006zt-Bc; Fri, 05 Jan 2007 00:14:01 +0300 From: Vladimir Prus To: Nick Roberts Subject: Re: [RFC] MI: Event notification Date: Thu, 04 Jan 2007 21:14:00 -0000 User-Agent: KMail/1.9.1 Cc: gdb-patches@sources.redhat.com References: <17817.40495.289353.14514@kahikatea.snap.net.nz> <17821.26712.100127.455097@kahikatea.snap.net.nz> In-Reply-To: <17821.26712.100127.455097@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200701050013.20576.ghost@cs.msu.su> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00146.txt.bz2 On Thursday 04 January 2007 23:49, Nick Roberts wrote: > > > The general idea is to report changes in program state to the frontend so > > > that it only updates the parts that need it. For example, after "up" > > > frame_changed_hook triggers and the frontend knows it has to update the > > > locals display. > > > > You mean, after "up" emitted explicitly by the user? If the frontend changes > > the frame itself, it does not need any notifications. > > It might not be by clicking on a button but by typing "up" or even "u" from > the console (GUD buffer). In such a case how would the frontend know that > the frame has changed? > > > > This means that stepping through a single frame should be much > > > quicker. If GDB enters a new frame during execution, stack_changed_hook > > > triggers and the frontend knows it has to update the call stack display. > > > I would eventually like to add more hooks like target-changed-hook when > > > the user attaches to/detaches from a process, kills the process, or > > > selects a new target with the "file" command. > > > > Is this all for user-typed commands? I wonder if notifications for those are > > really needed. Reloading entire UI state after a user command does not seem > > too bad -- because user is not likely to enter 10 commands per second anyway > > -- and is much simpler. > > With a large stack and stepping through the program, I think it is very > noticeable, which is why I frequently try to select a line to run to. Stepping through the code and typing CLI commands are rather different activities. For entering CLI, full UI state reload is not so problematic. For stepping: 1. I have a proposal for "-var-list --locals" that I think will make work with local variables very convenient and fast. I'll post that tomorrow. 2. As for -stack-* -- if there any reason why that code cannot detect that stack has not changed and quickly return "cached" result. That will optimize all existing frontends automatically. > > > The hooks are inserted/removed through "interpreter-exec console > > > cli-command" > > > > Sorry, can you clarify? > > In mi_cmd_interpreter_exec, there are calls to mi_insert_notify_hooks and > mi_remove_notify_hooks. Ok. > > > so I envisage not using MI commands like -exec-run, > > > -exec-next, -stack-select-frame that change that state. > > mi_cmd_interpreter_exec only gets called with "interpreter-exec" so there > would be no event notification in this case. I suppose frontend can check if the input starts with "-" and do full reload in that case, anyway? - Volodya