From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30398 invoked by alias); 3 Jan 2007 22:59:39 -0000 Received: (qmail 30390 invoked by uid 22791); 3 Jan 2007 22:59:38 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Wed, 03 Jan 2007 22:59:34 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1H2F51-0007DY-71; Wed, 03 Jan 2007 17:59:31 -0500 Date: Wed, 03 Jan 2007 22:59:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: Vladimir Prus , gdb-patches@sources.redhat.com Subject: Re: [PATCH] MI: new timing command Message-ID: <20070103225931.GR17935@nevyn.them.org> Mail-Followup-To: Nick Roberts , Vladimir Prus , gdb-patches@sources.redhat.com References: <17814.10139.269708.848818@kahikatea.snap.net.nz> <17815.23981.229049.700927@kahikatea.snap.net.nz> <20061231150951.GB16449@nevyn.them.org> <17816.35183.413527.741415@farnswood.snap.net.nz> <20070103180059.GB17935@nevyn.them.org> <17820.9474.773413.259028@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17820.9474.773413.259028@kahikatea.snap.net.nz> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00093.txt.bz2 On Thu, Jan 04, 2007 at 10:49:54AM +1300, Nick Roberts wrote: > > I don't even understand why we're having this conversation. Please > > follow the coding standard unless you have a good justification not to; > > that's why we call it the standard. Thanks. > > Sure, I didn't say that I wouldn't do it. I'm just waiting for Eli to tell > me if it works with get_run_time. Meanwhile here's a revised version of > mi-main.c. I've even made line breaks before, instead of after, operators! Please... (from gdb/CONTRIBUTE): o Please read your patch before submitting it. A patch containing several unrelated changes or arbitrary reformats will be returned with a request to re-formatting / split it. If you're volunteering to fix up formatting in the MI files, go right ahead; patches which only fix formatting problems are obvious, as long as you've proofread them. But patches which mix code changes and formatting changes are pretty much impossible to read. The one you just posted, for instance, was 40K and had about twenty lines of actual new code in it. -- Daniel Jacobowitz CodeSourcery