Re: RFC: Use -Wall -Wextra

Eli Zaretskii
2006-12-29T12:13:32Z

> Date: Thu, 28 Dec 2006 14:55:33 -0500
> From: Daniel Jacobowitz <drow@false.org>
>
> I'd like to hear opinions on this patch. It changes the default set of GDB
> build warnings from:
>
> build_warnings="-Wimplicit -Wreturn-type -Wcomment -Wtrigraphs \
> -Wformat -Wparentheses -Wpointer-arith -Wformat-nonliteral \
> -Wunused-label -Wunused-function -Wno-pointer-sign"
>
> to:
>
> build_warnings="-Wall -Wextra -Wpointer-arith -Wformat-nonliteral \
> -Wno-pointer-sign -Wno-unused-parameter \
> -Wno-unused -Wno-sign-compare -Wno-switch -Wno-missing-field-initializers"

I would agree only if we never try to use -Werror, because with such
aggressive warnings GDB will never build if we add -Werror.

My other fear is that, with GCC becoming more and more picky about
perfectly valid C code, these options will cause the compilation to
become very noisy, but I guess we will hear complaints if that
happens.

> I'd really like to turn on -Wunused too, but it has been off for so long
> that we have a substantial number of unused local variables - it will take
> some work to clean up.

I'd advise against -Wunused: the problems it finds are harmless,
whereas fixing them is not trivial at all, and quite ugly in some
cases.

> Index: doc/gdbint.texinfo
> ===================================================================
> RCS file: /cvs/src/src/gdb/doc/gdbint.texinfo,v
> retrieving revision 1.247
> diff -u -p -r1.247 gdbint.texinfo
> --- doc/gdbint.texinfo 10 Nov 2006 19:20:37 -0000 1.247
> +++ doc/gdbint.texinfo 28 Dec 2006 19:39:07 -0000

This is fine with me, thanks.