From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25964 invoked by alias); 3 Jan 2007 14:44:32 -0000 Received: (qmail 25954 invoked by uid 22791); 3 Jan 2007 14:44:31 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Wed, 03 Jan 2007 14:44:25 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1H27Lr-0003Kv-8U; Wed, 03 Jan 2007 09:44:23 -0500 Date: Wed, 03 Jan 2007 14:44:00 -0000 From: Daniel Jacobowitz To: Denis PILAT Cc: gdb-patches Subject: Re: [RFA] gdbserver with reversed arguments seg. fault Message-ID: <20070103144423.GB12452@nevyn.them.org> Mail-Followup-To: Denis PILAT , gdb-patches References: <459B778D.4000500@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <459B778D.4000500@st.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00063.txt.bz2 On Wed, Jan 03, 2007 at 10:29:49AM +0100, Denis PILAT wrote: > Hi, > > Following our discussion in the thread > http://sources.redhat.com/ml/gdb-patches/2007-01/msg00059.html > I'm proposing the attached patch to fix a segmentation fault that occurs > into gdbserver when you revert the binary filename with the "host:port" > argument. > In inferiors.c the inferior_target_data() function is called with a NULL > pointer argument. At the beginning I though of testing arguments but > none of them are tested in this whole file so I concluded it's up to the > caller to do so. What exactly did you do to get this crash? What's the backtrace look like? It didn't happen for me. -- Daniel Jacobowitz CodeSourcery