From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18791 invoked by alias); 3 Jan 2007 02:47:36 -0000 Received: (qmail 18782 invoked by uid 22791); 3 Jan 2007 02:47:35 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Wed, 03 Jan 2007 02:47:30 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1H1wA3-0007zZ-JP; Tue, 02 Jan 2007 21:47:27 -0500 Date: Wed, 03 Jan 2007 02:47:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Add support for catch Ada exceptions (take 2) Message-ID: <20070103024727.GA30512@nevyn.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sourceware.org References: <20061230032111.GB27642@adacore.com> <20061231213707.GA26604@nevyn.them.org> <20070101044301.GF3428@adacore.com> <20070101161914.GA13508@nevyn.them.org> <20070102060712.GG17211@adacore.com> <20070102061526.GH17211@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070102061526.GH17211@adacore.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00058.txt.bz2 On Tue, Jan 02, 2007 at 10:15:26AM +0400, Joel Brobecker wrote: > Apart from that, I'm pretty happy the way the exercise turned out. Me too. This is OK with just two things: I mentioned xstrprintf to avoid duplicating strings in another message around when you posted this, and some calls to error don't use _(). The bits in is_known_support_routine are definitely improvable. It seems that I should have added some sort of baton to the breakpoint_ops; that would save you a bunch of stub functions. If you think that's a good idea, feel free to give it a try :-) But no need. > (exception_catchpoint_kind): New enum. > (function_name_from_pc): New function. > (is_known_support_routine): New function. > (ada_find_printable_frame): New function. You can probably cut this to half the length if you put two functions on each line: (exception_catchpoint_kind, function_name_from_pc) (is_known_support_routine, ada_find_printable_frame): New. [Except for all of them.] > NEWS entry and documentation will follow shortly after approval. Yes please :-) -- Daniel Jacobowitz CodeSourcery