From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17630 invoked by alias); 31 Dec 2006 16:09:36 -0000 Received: (qmail 17621 invoked by uid 22791); 31 Dec 2006 16:09:34 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO brahms.sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 31 Dec 2006 16:09:27 +0000 Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by brahms.sibelius.xs4all.nl (8.13.8/8.13.8) with ESMTP id kBVG9GAI030452; Sun, 31 Dec 2006 17:09:16 +0100 (CET) Received: (from kettenis@localhost) by brahms.sibelius.xs4all.nl (8.13.8/8.13.8/Submit) id kBVG9Fgh022431; Sun, 31 Dec 2006 17:09:15 +0100 (CET) Date: Sun, 31 Dec 2006 16:09:00 -0000 Message-Id: <200612311609.kBVG9Fgh022431@brahms.sibelius.xs4all.nl> From: Mark Kettenis To: ghost@cs.msu.su CC: mark.kettenis@xs4all.nl, gdb-patches@sources.redhat.com In-reply-to: (message from Vladimir Prus on Sun, 31 Dec 2006 18:37:58 +0300) Subject: Re: [PATCH] MI: new timing command References: <17814.10139.269708.848818@kahikatea.snap.net.nz> <17814.58031.865155.682869@kahikatea.snap.net.nz> <20061231042547.GA3236@nevyn.them.org> <17815.18190.987950.612053@kahikatea.snap.net.nz> <20061231054946.GA4873@nevyn.them.org> <17815.27092.497145.908734@kahikatea.snap.net.nz> <20061231151527.GC16449@nevyn.them.org> <200612311524.kBVFObud010411@brahms.sibelius.xs4all.nl> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00413.txt.bz2 > X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on > zigzag.lvk.cs.msu.su > X-Spam-Level: > X-Spam-Status: No, score=-4.4 required=5.5 tests=ALL_TRUSTED,BAYES_00 > autolearn=ham version=3.1.7 > From: Vladimir Prus > Date: Sun, 31 Dec 2006 18:37:58 +0300 > X-XS4ALL-DNSBL-Checked: mxdrop37.xs4all.nl checked 158.250.17.23 against DNS blacklists > X-Virus-Scanned: by XS4ALL Virus Scanner > X-XS4ALL-Spam-Score: 0.0 () DK_POLICY_SIGNSOME,UNPARSEABLE_RELAY > X-XS4ALL-Spam: NO > Envelope-To: mark.kettenis@xs4all.nl > X-UIDL: 1167579527._smtp.mxdrop37.60237,S=2952 > > Mark Kettenis wrote: > > >> Date: Sun, 31 Dec 2006 10:15:27 -0500 > >> From: Daniel Jacobowitz > >> > >> On Sun, Dec 31, 2006 at 08:42:12PM +1300, Nick Roberts wrote: > >> > Daniel Jacobowitz writes: > >> > > In that case you can copy the necessary guards from that file. > >> > > However, it does more than just getrusage - it also supports > >> > > platforms with times() but without getrusage, which IIRC includes > >> > > Windows, so it might be better to use it. > >> > > >> > But as a last resort it returns elapsed time which would be wrong. > >> > >> You keep saying this but I don't see why. Why is it wrong? On every > >> platform where we can do it, we'll print usage; on platforms where we > >> can't do it, the odds are pretty good that the OS isn't aggressively > >> scheduling other tasks in while we're running, so wall time is pretty > >> close to right. > > > > I agree completely. > > Is this important? This timing is entirely for diagnostic purposes, > so why try to make it work on every possible platform. We need to document > that -enable-timing may fail, and that's it. The point is to use get_run_time() from -liberty and never worry about portability again.