From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3104 invoked by alias); 31 Dec 2006 15:10:08 -0000 Received: (qmail 3096 invoked by uid 22791); 31 Dec 2006 15:10:07 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Sun, 31 Dec 2006 15:10:02 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1H12Jr-0004M3-8h; Sun, 31 Dec 2006 10:09:51 -0500 Date: Sun, 31 Dec 2006 15:10:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: Vladimir Prus , gdb-patches@sources.redhat.com Subject: Re: [PATCH] MI: new timing command Message-ID: <20061231150951.GB16449@nevyn.them.org> Mail-Followup-To: Nick Roberts , Vladimir Prus , gdb-patches@sources.redhat.com References: <17814.10139.269708.848818@kahikatea.snap.net.nz> <17815.23981.229049.700927@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17815.23981.229049.700927@kahikatea.snap.net.nz> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00405.txt.bz2 On Sun, Dec 31, 2006 at 07:50:21PM +1300, Nick Roberts wrote: > > Dot at the end of the sentence. The above sounds like this > > structure hold two separate timestaps -- for current command > > and the last async command. Maybe replacing "and" with "or" will help. > > There are *many* instances of one line comments in this file without a full > stop. Perhaps the practice is just to give multi-line comments a full stop > (maybe one liners are regarded as phrases). The file does contain errors; that's not a good reason to add additional errors. The GDB and GNU style is to use the full stop. -- Daniel Jacobowitz CodeSourcery