From: Mark Kettenis <kettenis@sibelius.xs4all.nl>
To: brobecker@adacore.com
Cc: mark.kettenis@xs4all.nl, gdb-patches@sourceware.org
Subject: Re: [RFA/sparc64] internal-error printing return value (Ada array) - take 2
Date: Sun, 24 Dec 2006 14:58:00 -0000 [thread overview]
Message-ID: <200612241458.kBOEw8uf016599@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <20061224093615.GH19684@adacore.com> (message from Joel Brobecker on Sun, 24 Dec 2006 13:36:15 +0400)
> Date: Sun, 24 Dec 2006 13:36:15 +0400
> From: Joel Brobecker <brobecker@adacore.com>
>
> Hello Mark,
>
> Following our disccussion that started at:
>
> http://www.sourceware.org/ml/gdb-patches/2006-11/msg00076.html
>
> I finally found the time to make the change you suggested, and then
> test it again.
>
> 2006-12-24 Joel Brobecker <brobecker@adacore.com>
>
> * sparc64-tdep.c (sparc64_extract_return_value): Add handling
> for array types.
> (sparc64_store_return_value): Likewise.
>
> Tested on sparc64-sun-solaris2.8, no regression. OK to commit?
Could you change the comment from
/* Small arrays are returned the same way as small records. */
into
/* Small arrays are returned the same way as small structures. */
?
With that change this is ok.
However, did you check how small arrays of floating-point numbers are returned?
I suspect there might be an issue with those.
Mark
next prev parent reply other threads:[~2006-12-24 14:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-24 9:35 Joel Brobecker
2006-12-24 14:58 ` Mark Kettenis [this message]
2006-12-26 5:12 ` Joel Brobecker
2006-12-26 13:44 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200612241458.kBOEw8uf016599@brahms.sibelius.xs4all.nl \
--to=kettenis@sibelius.xs4all.nl \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox