From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15306 invoked by alias); 22 Dec 2006 06:18:30 -0000 Received: (qmail 15298 invoked by uid 22791); 22 Dec 2006 06:18:29 -0000 X-Spam-Check-By: sourceware.org Received: from zigzag.lvk.cs.msu.su (HELO zigzag.lvk.cs.msu.su) (158.250.17.23) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 22 Dec 2006 06:18:25 +0000 Received: from Debian-exim by zigzag.lvk.cs.msu.su with spam-scanned (Exim 4.50) id 1GxdjZ-0002Za-Ot for gdb-patches@sources.redhat.com; Fri, 22 Dec 2006 09:18:22 +0300 Received: from localhost ([127.0.0.1] helo=ip6-localhost) by zigzag.lvk.cs.msu.su with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.50) id 1GxdjV-0002ZN-9D; Fri, 22 Dec 2006 09:18:17 +0300 From: Vladimir Prus To: Nick Roberts Subject: Re: Cleanup varobj children handling Date: Fri, 22 Dec 2006 06:18:00 -0000 User-Agent: KMail/1.9.1 Cc: gdb-patches@sources.redhat.com References: <200612082300.06688.ghost@cs.msu.su> <17803.3261.229888.723300@kahikatea.snap.net.nz> In-Reply-To: <17803.3261.229888.723300@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200612220918.15378.ghost@cs.msu.su> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00300.txt.bz2 On Friday 22 December 2006 01:37, Nick Roberts wrote: > > > This patch changes varobj.c to use VEC for hodling children, thereby > > > making three functions unnecessary. No regressions in MI tests. OK? > > > > Here's a revised patch, that additionally replaces 'vstack' code in varobj.c > > with VEC(). All in all, some 130 lines of code gets wiped now. OK? > > I'm not familiar with vec.c yet - perhaps you and Daniel J discussed this issue > privately - all I can say is that varobj. c has the comment: > > /* Every variable keeps a linked list of its children, described > by the following structure. */ > /* FIXME: Deprecated. All should use vlist instead */ > > Buy perhaps this is not relevant. The comment was written before vec.c was available, so it naturally does not suggest vec.c. - Volodya