From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21320 invoked by alias); 21 Dec 2006 11:08:41 -0000 Received: (qmail 21306 invoked by uid 22791); 21 Dec 2006 11:08:40 -0000 X-Spam-Check-By: sourceware.org Received: from nile.gnat.com (HELO nile.gnat.com) (205.232.38.5) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 21 Dec 2006 11:08:28 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-nile.gnat.com (Postfix) with ESMTP id C692848CE88; Thu, 21 Dec 2006 06:08:23 -0500 (EST) Received: from nile.gnat.com ([127.0.0.1]) by localhost (nile.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 25189-01-3; Thu, 21 Dec 2006 06:08:23 -0500 (EST) Received: from takamaka.act-europe.fr (AStDenis-105-1-71-21.w80-8.abo.wanadoo.fr [80.8.210.21]) by nile.gnat.com (Postfix) with ESMTP id B41E448D075; Thu, 21 Dec 2006 06:08:17 -0500 (EST) Received: by takamaka.act-europe.fr (Postfix, from userid 1000) id 44B4734C099; Thu, 21 Dec 2006 15:09:04 +0400 (RET) Date: Thu, 21 Dec 2006 11:08:00 -0000 From: Joel Brobecker To: Markus Deuling Cc: GDB Patches Subject: Re: [RFA] gdbserver/server.c: Replace 2x strlen() by a variable Message-ID: <20061221110904.GG3640@adacore.com> References: <458A3B6C.2040803@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <458A3B6C.2040803@de.ibm.com> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00285.txt.bz2 > ChangeLog: > > * server.c (handle_general_set): New variable len instead > of using strlen two times. Actually, since the same string is duplicated a couple of times, I would also suggest declaring a constant string "QPassSignals:" and use the constant instead of risking a typo... How about: const char str[] = "QPassSignals:"; and then use "sizeof (str) - 1". Is that bad coding style? Otherwise, you can declare your sale constant: const int len = strlen (str); I am not reviewer, so these are just suggestions, not a request (JIC). > ========================================= > diff -urN src/gdb/gdbserver/server.c dev/gdb/gdbserver/server.c > --- src/gdb/gdbserver/server.c 2006-12-21 08:38:11.000000000 +0100 > +++ dev/gdb/gdbserver/server.c 2006-12-21 08:38:25.000000000 +0100 > @@ -163,10 +163,11 @@ > void > handle_general_set (char *own_buf) > { > - if (strncmp ("QPassSignals:", own_buf, strlen ("QPassSignals:")) == 0) > + int len = strlen ("QPassSignals:"); > + if (strncmp ("QPassSignals:", own_buf, len) == 0) > { > int numsigs = (int) TARGET_SIGNAL_LAST, i; > - const char *p = own_buf + strlen ("QPassSignals:"); > + const char *p = own_buf + len; > CORE_ADDR cursig; > > p = decode_address_to_semicolon (&cursig, p); > > Regards, > Markus > > -- > Markus Deuling > GNU Toolchain for Linux on Cell BE > deuling@de.ibm.com -- Joel