Re: [mi] [ada] varobjs for registers 2

Daniel Jacobowitz
2006-12-30T20:30:28Z

On Wed, Dec 20, 2006 at 09:37:28PM +0300, Vladimir Prus wrote:
>
> This is a second revision of the patch to add MI command that
> creates varobjs for registers. The command is renamed to -var-list
> and used like:
>
> -var-list --registers
>
> There are now docs and tests. The created variable objects no longer
> have 'public' pseudo-fields, no matter what the language of the program is.
>
> Along the way, I've promoted a private function in ada-lang.c to language.c,
> so I'd appreciate if Ada maintainers take a quick look.
>
> OK?

Before I look at this, is it the latest version? You and Nick had an
active discussion about this while I was on vacation.

On Thu, Dec 21, 2006 at 11:21:02AM +0400, Joel Brobecker wrote:
> I believe the comment describing the function should be placed besides
> the function implementation, in language.c. This is the habit we have
> at least in the GNU projects I've been involved in. In Ada, we much
> prefer to place the documentation besides the declaration, as you did,
> but C allows you to put as many declarations of the same entity as you
> want, and wherever you want. So this conventions allows us to know
> exactly where the documentation is...

GDB is inconsistent about this, so I don't think it makes much
difference. I've been putting the comments in headers for global
functions and referring to the header from the implementation,
but that's not great either.

--
Daniel Jacobowitz
CodeSourcery