From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18070 invoked by alias); 15 Dec 2006 16:37:47 -0000 Received: (qmail 18061 invoked by uid 22791); 15 Dec 2006 16:37:46 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 15 Dec 2006 16:37:34 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1GvG3u-0002Zq-9W; Fri, 15 Dec 2006 11:37:30 -0500 Date: Fri, 15 Dec 2006 16:37:00 -0000 From: Daniel Jacobowitz To: Nick Hudson Cc: gdb-patches@sources.redhat.com Subject: Re: PATCH: Provde a pid to filename conversion for NetBSD Message-ID: <20061215163730.GA9822@nevyn.them.org> Mail-Followup-To: Nick Hudson , gdb-patches@sources.redhat.com References: <200611301323.18743.skrll@netbsd.org> <200612151623.30618.skrll@netbsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200612151623.30618.skrll@netbsd.org> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00199.txt.bz2 On Fri, Dec 15, 2006 at 04:23:30PM +0000, Nick Hudson wrote: > > 2006-11-30 Nick Hudson > > > > * i386nbsd-nat.c: Include "nbsd-nat.h". > > (_initialize_i386nbsd_nat): Update target vector to use > > nbsd_pid_to_exec_file. > > > > * config/i386/nbsdelf.mh (NATDEPFILES): Add nbsd-nat.o > > > > * nbsd-nat.c: New file. > > * nbsd-nat.h: New file. > > * Makefile.in (ALLDEPFILES): Add nbsd-nat.c. > > (nbsd_nat_h): New variable. > > (nbsd-nat.o): New dependency. > > What needs to happen for this to go in? Someone needs to review it. I was hoping that someone who actually used NetBSD would speak up :-) If no one does, I'll do it myself. It looks generally fine. Is this going to work for every NetBSD platform? Should it be added to all of them, rather than just i386? Looks like GDB supports 11. -- Daniel Jacobowitz CodeSourcery