From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19562 invoked by alias); 13 Dec 2006 13:52:39 -0000 Received: (qmail 19547 invoked by uid 22791); 13 Dec 2006 13:52:38 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate4.de.ibm.com (HELO mtagate4.de.ibm.com) (195.212.29.153) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 13 Dec 2006 13:52:25 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate4.de.ibm.com (8.13.8/8.13.8) with ESMTP id kBDDqHMe075902 for ; Wed, 13 Dec 2006 13:52:20 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.6/8.13.6/NCO v8.1.1) with ESMTP id kBDDqHFU3067986 for ; Wed, 13 Dec 2006 14:52:17 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id kBDDqHk1009849 for ; Wed, 13 Dec 2006 14:52:17 +0100 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id kBDDqHN6009841; Wed, 13 Dec 2006 14:52:17 +0100 Message-Id: <200612131352.kBDDqHN6009841@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 13 Dec 2006 14:52:17 +0100 Subject: Re: [RFA] Implement Cell BE SPU-specific vector type To: deuling@de.ibm.com (Markus Deuling) Date: Wed, 13 Dec 2006 13:52:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org (GDB Patches) In-Reply-To: <45800270.2050508@de.ibm.com> from "Markus Deuling" at Dec 13, 2006 02:38:56 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00174.txt.bz2 Hi Markus, > there were problems with whitespaces in the last patch I posted, so here > it is again. I'm sorry, but this has exactly the same problems as last time ... > * spu-tdep.c (spu_init_vector_type): New function. > (spu_builtin_type_vec128.): New static variable. > (spu_register_type): Return spu_builtin_type_vec128 as default. > (_initialize_spu_tdep): Call spu_init_vector_type. Otherwise the patch is OK, can you either re-send with a fixed mailer or as attachment? Some problems: > @@ -84,7 +86,7 @@ > spu_register_type (struct gdbarch *gdbarch, int reg_nr) > { > if (reg_nr < SPU_NUM_GPRS) > - return builtin_type_vec128; > + return spu_builtin_type_vec128; > > switch (reg_nr) > { All context lines without - or + start out with one space too many. > + struct type *type; > + > + type = init_composite_type ("__spu_builtin_type_vec128", > TYPE_CODE_UNION); Some lines are broken up ... Maybe this > Content-Type: text/plain; charset=ISO-8859-15; format=flowed has something to do with the problem. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com