From: Daniel Jacobowitz <drow@false.org>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] MI: -var-update bug
Date: Fri, 08 Dec 2006 20:04:00 -0000 [thread overview]
Message-ID: <20061208200434.GA25405@nevyn.them.org> (raw)
In-Reply-To: <17785.49735.481567.393065@kahikatea.snap.net.nz>
On Sat, Dec 09, 2006 at 08:51:35AM +1300, Nick Roberts wrote:
> > That reinit_frame_cache call is silly. I've been meaning to remove it
> > for ages. Do you see any reason not to?
>
> I don't understand frame.c well enough to judge yet (likewise with eval.c and
> your patch) but if you think its silly lets remove it. Without randomisation,
> I think some of this code (in c_value_of_root) would put the variable object
> back into scope because it would find the frame id.
>
> More generally, should we make GDB delete all variable objects if we restart
> execution or are there OSes (without randomisation) where it is still useful?
Randomisation isn't even the issue - I think that what you've got now
is simply an accident, and varobjs associated with a particular frame
should not become valid if a similar looking frame reappears later.
Right now we never delete varobjs automatically. We could preserve
that, but set a flag on the varobjs indicating they're permanently out
of scope?
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-12-08 20:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-08 19:38 Nick Roberts
2006-12-08 19:43 ` Daniel Jacobowitz
2006-12-08 19:56 ` Nick Roberts
2006-12-08 20:04 ` Daniel Jacobowitz [this message]
2006-12-08 20:09 ` Nick Roberts
2006-12-08 20:23 ` Daniel Jacobowitz
2006-12-09 20:47 ` Nick Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061208200434.GA25405@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox