From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9239 invoked by alias); 7 Dec 2006 14:39:05 -0000 Received: (qmail 9219 invoked by uid 22791); 7 Dec 2006 14:39:02 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Thu, 07 Dec 2006 14:38:55 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1GsKOd-0003Le-Db; Thu, 07 Dec 2006 09:38:47 -0500 Date: Thu, 07 Dec 2006 14:39:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: MI/C++/references fixup Message-ID: <20061207143847.GA12813@nevyn.them.org> Mail-Followup-To: Vladimir Prus , gdb-patches@sources.redhat.com References: <200611291215.21876.vladimir@codesourcery.com> <17774.7608.862541.696058@kahikatea.snap.net.nz> <200611301031.07625.vladimir@codesourcery.com> <200611291715.05247.vladimir@codesourcery.com> <20061129142435.GD29365@nevyn.them.org> <200611291741.13617.vladimir@codesourcery.com> <20061205211129.GB27898@nevyn.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00096.txt.bz2 On Wed, Dec 06, 2006 at 12:16:45PM +0300, Vladimir Prus wrote: > Here's revised patch. Ok for HEAD? > > - Volodya > > * varobj.c (varobj_create): Don't call release_value. > (varobj_set_value): Likewise. > (install_new_value): Call coerce_ref and release_value > on the value. Add asserts. > > testsuite/ > * lib/mi-support.exp > (mi_runto): Accept "()" after function name. > (mi_create_varobj): New function. > (mi_varobj_update): New function. > (mi_Check_varobj_value): New function. > * gdb.mi/mi-var-cp.exp: New file. > * gdb.mi/mi-var-cp.cc: New file. Yes, this is OK. Thanks! -- Daniel Jacobowitz CodeSourcery