Re: [RFA][2/5] New port: Cell BE SPU (valops.c fix)

Daniel Jacobowitz
2006-11-22T14:23:08Z

On Sat, Nov 11, 2006 at 07:38:17PM +0100, Ulrich Weigand wrote:
> The patch below 'fixes' this for SPU by at least not calling
> VALUE_TO_REGISTER for bitfield assignments, but falling back
> to the default code. This happens to work for SPU; other
> platforms with special conversion needs might need to get a
> chance for the back-end to get involved even then. I guess
> when this happens we can think of an extended interface that
> would pass the bitsize information through to the back-end ...

I've got to admit that I don't like it :-(

VALUE_TO_REGISTER has only one caller and eight definitions (plus some
documentation). It shouldn't be hard to update it. What additional
information do you need? Would passing the two values instead of one
regnum and one contents do it?

--
Daniel Jacobowitz
CodeSourcery