From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10192 invoked by alias); 6 Dec 2006 20:07:06 -0000 Received: (qmail 10080 invoked by uid 22791); 6 Dec 2006 20:07:05 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Wed, 06 Dec 2006 20:06:58 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1Gs32d-0002YK-LO; Wed, 06 Dec 2006 15:06:55 -0500 Date: Wed, 06 Dec 2006 20:07:00 -0000 From: Daniel Jacobowitz To: Jim Blandy Cc: gdb-patches@sourceware.org Subject: Re: Now I know why we used to swap builtin_type_void. Message-ID: <20061206200655.GA9791@nevyn.them.org> Mail-Followup-To: Jim Blandy , gdb-patches@sourceware.org References: <20061206195227.GA9228@nevyn.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00074.txt.bz2 On Wed, Dec 06, 2006 at 12:05:11PM -0800, Jim Blandy wrote: > Why doesn't the same logic apply to the other types created in > _initialize_gdbtypes? I believe they're never referred to by debug > information, and the user has no way to refer to them from the command > line, so that keeps us out of trouble in those cases. But if some > architecture-specific code ever calls lookup_pointer_type on them, > won't we have the same problem you've discovered above with void? Exactly. I think we'd have to move TYPE_POINTER_TYPE out of the type and into e.g. an architecture hash table to fix this. Worth it? Don't know. > I'll revert the patch. It was just a cleanup; I don't actually need > it for anything. Thanks. -- Daniel Jacobowitz CodeSourcery