From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20415 invoked by alias); 5 Dec 2006 21:12:24 -0000 Received: (qmail 20403 invoked by uid 22791); 5 Dec 2006 21:12:23 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 05 Dec 2006 21:12:17 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1GrhaI-0007Nr-6i; Tue, 05 Dec 2006 16:12:14 -0500 Date: Tue, 05 Dec 2006 21:12:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: gdb-patches@sources.redhat.com Subject: Re: MI: fix base members in references Message-ID: <20061205211214.GA28333@nevyn.them.org> Mail-Followup-To: Nick Roberts , gdb-patches@sources.redhat.com References: <17781.56458.807690.396014@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17781.56458.807690.396014@kahikatea.snap.net.nz> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00042.txt.bz2 On Wed, Dec 06, 2006 at 09:54:34AM +1300, Nick Roberts wrote: > > > > The attached patch fixed the problem, no regression. I'll write a testcase > > > for it as soon as my previous references patch is reviewed -- I don't want > > > to > pile too many testcases in as-yet-uncommitted file. > > > > > > OK? > > > OK, with a changelog entry. > > Actually Vladimir's other patch, MI/C++/references fixup > (http://sourceware.org/ml/gdb-patches/2006-11/msg00373.html), seems to fix > this. As it also fixes the more general problem of updating references can > this not be applied instead? They can both go in as far as I'm concerned; I think they're both needed. I hadn't got to that one yet. -- Daniel Jacobowitz CodeSourcery