From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19976 invoked by alias); 5 Dec 2006 21:11:38 -0000 Received: (qmail 19962 invoked by uid 22791); 5 Dec 2006 21:11:37 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 05 Dec 2006 21:11:32 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1GrhZZ-0007Mv-Gr; Tue, 05 Dec 2006 16:11:29 -0500 Date: Tue, 05 Dec 2006 21:11:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: gdb-patches@sources.redhat.com, Nick Roberts Subject: Re: MI/C++/references fixup Message-ID: <20061205211129.GB27898@nevyn.them.org> Mail-Followup-To: Vladimir Prus , gdb-patches@sources.redhat.com, Nick Roberts References: <200611291215.21876.vladimir@codesourcery.com> <200611291741.13617.vladimir@codesourcery.com> <17774.7608.862541.696058@kahikatea.snap.net.nz> <200611301031.07625.vladimir@codesourcery.com> <200611291215.21876.vladimir@codesourcery.com> <200611291715.05247.vladimir@codesourcery.com> <20061129142435.GD29365@nevyn.them.org> <200611291741.13617.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200611301031.07625.vladimir@codesourcery.com> <200611291741.13617.vladimir@codesourcery.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00041.txt.bz2 On Wed, Nov 29, 2006 at 05:41:13PM +0300, Vladimir Prus wrote: > +# Creates varobj named NAME for EXPRESSION. > +# Name cannot be "-". > +proc mi_create_varobj { name expression } { > +# Updates varobj named NAME and checks that all varobjs in EXPECTED > +# are reported as updated, and no other varobj is updated. > +# Assumes that no varobj is out of scope and that no varobj changes > +# types. > +proc mi_varobj_update { name expected } { > +proc mi_check_varobj_value { name value } { I would recommend giving these an argument for the test name, as some of the other helper functions do. Otherwise, if you call them twice in a row with the same arguments (which your test does) then you've got two tests with the same name. On Thu, Nov 30, 2006 at 10:31:07AM +0300, Vladimir Prus wrote: > > * gdb.mi/mi-cpp.cpp: New file. > > > > gdb.mi/mi-var-cp.exp? > > gdb.mi/mi-var-cp.cc? > > > > Its for variable objects, and for consistency. The testsuite has the > > directory gdb.cp and it's populated with *.cc files > > I've no problems with 'cp' and '.cc'. I don't think that '-var-' is good -- > now, there is just single MI test dealing with C++, so I want a testcase that > will accumulate all C++ specific things, not necessary related to variable > objects. But I don't care much. I'd rather keep varobj tests easily identifiable; please use Nick's suggestions. -- Daniel Jacobowitz CodeSourcery