From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10155 invoked by alias); 5 Dec 2006 21:02:41 -0000 Received: (qmail 10147 invoked by uid 22791); 5 Dec 2006 21:02:40 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 05 Dec 2006 21:02:33 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1GrhQt-0007Hk-Cf; Tue, 05 Dec 2006 16:02:31 -0500 Date: Tue, 05 Dec 2006 21:02:00 -0000 From: Daniel Jacobowitz To: Jean-Marc Saffroy Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] gdb script performance Message-ID: <20061205210231.GA27719@nevyn.them.org> Mail-Followup-To: Jean-Marc Saffroy , gdb-patches@sources.redhat.com References: <20061130031323.GA25957@nevyn.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00040.txt.bz2 On Thu, Nov 30, 2006 at 02:56:54PM +0100, Jean-Marc Saffroy wrote: > For the PC cache, I guess that just about any address can be passed, so I > doubt there is much room for improvement (except maybe a cache with more > than one entry, should it be useful in some cases, but now it's probably > unneeded). We shouldn't need to cache at all. I think the right representation would allow us to look up a single PC and find the best psymtab based on that PC without having to loop over psymtabs; this requires a pretty big change to the way we store things, since unfortunately I don't think we can assume the address ranges of psymtabs are even remotely sane (multiple psymtabs may overlap, for instance, and it's past time we started recording DW_AT_ranges discontiguous range information). Not sure what a good data structure for that would look like. -- Daniel Jacobowitz CodeSourcery