Re: PATCH: PR tui/2173: Arrow keys no longer works in breakpoint command list

H. J. Lu
2006-11-28T17:09:39Z

On Tue, Nov 28, 2006 at 11:46:58AM -0500, Daniel Jacobowitz wrote:
> On Tue, Nov 21, 2006 at 01:32:05PM -0800, H. J. Lu wrote:
> > The problem is callback in readline 5.1 is changed. When gdb readline
> > callback calls readline (), readline is really confused since although
> > it is called from gdb callback, it isn't really in callback state. This
> > kludge seems to work for me.
>
> I'm pretty sure this isn't right. I got as far as figuring out that we
> should be calling rl_callback_handler_install and
> rl_callback_handler_remove at different times, always removing the
> handler before calling readline recursively, but I couldn't quite work
> out the right conditions.

I assume by "this isn't right", you mean my patch may break something.
Do you have a testcase? It may get into readline:

http://lists.gnu.org/archive/html/bug-readline/2006-11/msg00011.html

H.J.