From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18702 invoked by alias); 1 Dec 2006 00:07:44 -0000 Received: (qmail 18569 invoked by uid 22791); 1 Dec 2006 00:07:38 -0000 X-Spam-Check-By: sourceware.org Received: from nile.gnat.com (HELO nile.gnat.com) (205.232.38.5) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 01 Dec 2006 00:07:29 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-nile.gnat.com (Postfix) with ESMTP id 224EA48CE2A; Thu, 30 Nov 2006 19:07:27 -0500 (EST) Received: from nile.gnat.com ([127.0.0.1]) by localhost (nile.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 09190-01-8; Thu, 30 Nov 2006 19:07:26 -0500 (EST) Received: from takamaka.act-europe.fr (S0106000f3d96cb6d.vc.shawcable.net [24.84.195.170]) by nile.gnat.com (Postfix) with ESMTP id D487348CBC3; Thu, 30 Nov 2006 19:07:26 -0500 (EST) Received: by takamaka.act-europe.fr (Postfix, from userid 1000) id E001134C099; Thu, 30 Nov 2006 16:07:54 -0800 (PST) Date: Fri, 01 Dec 2006 00:07:00 -0000 From: Joel Brobecker To: Jim Blandy Cc: gdb-patches@sourceware.org Subject: Re: RFA: remove redundant code in ada-lang.c Message-ID: <20061201000754.GE6637@adacore.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00000.txt.bz2 Hi Jim, > I don't have an Ada compiler handy, so I can't test this, but does > this look right, Joel? It seems to me that since > ada_value_primitive_packed_val is passed arr as its 'obj' parameter, > v's lvalue type should already be set accordingly. > > 2006-11-22 Jim Blandy > > * ada-lang.c (value_subscript_packed): Don't bother to set the > lvalue type of the returned value here; > ada_value_primitive_packed_val takes care of that. Paul Hilfinger reviewed the patch for us and said that it looked good. I tested it on my laptop and showed no regression. Thanks for the patch! -- Joel