From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28438 invoked by alias); 29 Nov 2006 15:41:27 -0000 Received: (qmail 28426 invoked by uid 22791); 29 Nov 2006 15:41:25 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 29 Nov 2006 15:41:21 +0000 Received: (qmail 6286 invoked from network); 29 Nov 2006 15:41:18 -0000 Received: from unknown (HELO ?172.16.64.38?) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 29 Nov 2006 15:41:18 -0000 From: Vladimir Prus To: Daniel Jacobowitz Subject: Re: MI varobj printing cleanup Date: Wed, 29 Nov 2006 15:41:00 -0000 User-Agent: KMail/1.9.1 Cc: gdb-patches@sources.redhat.com References: <200611291824.16015.vladimir@codesourcery.com> <20061129153228.GB1348@nevyn.them.org> In-Reply-To: <20061129153228.GB1348@nevyn.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200611291841.08732.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00398.txt.bz2 On Wednesday 29 November 2006 18:32, Daniel Jacobowitz wrote: > On Wed, Nov 29, 2006 at 06:24:15PM +0300, Vladimir Prus wrote: > > + /* Not printing of the type below is wrong -- frontends can > > + be programmed easily if all creation of varobj always > > + return the same information. */ > > + print_varobj (*cc, print_values, 1 /* print expression */); > > + cc++; > > I don't understand this comment. Otherwise patch is OK. Nevermind, that's actually a topic for another patch in distant future. I've removed the comment and checked in. - Volodya