From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23701 invoked by alias); 29 Nov 2006 15:32:55 -0000 Received: (qmail 23677 invoked by uid 22791); 29 Nov 2006 15:32:51 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Wed, 29 Nov 2006 15:32:30 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1GpRQC-0000NZ-3O; Wed, 29 Nov 2006 10:32:28 -0500 Date: Wed, 29 Nov 2006 15:32:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: MI varobj printing cleanup Message-ID: <20061129153228.GB1348@nevyn.them.org> Mail-Followup-To: Vladimir Prus , gdb-patches@sources.redhat.com References: <200611291824.16015.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200611291824.16015.vladimir@codesourcery.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00396.txt.bz2 On Wed, Nov 29, 2006 at 06:24:15PM +0300, Vladimir Prus wrote: > + /* Not printing of the type below is wrong -- frontends can > + be programmed easily if all creation of varobj always > + return the same information. */ > + print_varobj (*cc, print_values, 1 /* print expression */); > + cc++; I don't understand this comment. Otherwise patch is OK. -- Daniel Jacobowitz CodeSourcery