Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Vladimir Prus <ghost@cs.msu.su>, Nick Roberts <nickrob@snap.net.nz>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Variable objects laziness
Date: Wed, 29 Nov 2006 13:45:00 -0000	[thread overview]
Message-ID: <20061129134447.GA29365@nevyn.them.org> (raw)
In-Reply-To: <17773.19183.730566.545997@kahikatea.snap.net.nz> <ekjcko$9j$1@sea.gmane.org>

FWIW, I do think this counted as an obvious fix, but it's near the
border indeed.  And, Nick is right; Vladimir, please do add yourself
to MAINTAINERS as write after approval.

On Wed, Nov 29, 2006 at 10:25:11AM +0300, Vladimir Prus wrote:
> > I think a further call to coerce_array is needed 
> 
> No, please no! Calls to coerce_array is exactly the reason for the other bug
> I'm fixing. This function has a nice property of silently coercing_refs,
> but that property is not documented, not obvious from function name and
> therefore should be considered a bug.

Let's please not change it though.  Too much of GDB expects the current
behavior...

> Attached (references.diff) is the patch that makes gdb sense the changes in
> reference values, and eliminates the address from the output. Any opinions?

IMVHO, we should still print the value, but only update if the contents
change; is that going to be a real pain to implement?
> +      /* If the value has changed, record it, so that next -var-update can
> +	 report this change.  If a variable had a value of '1', we've set it
> +	 to '333' and then set again to '1', when -var-update will report this

"then" rather than "when".  Otherwise patch is fine.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2006-11-29 13:45 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-29  8:59 Nick Roberts
2006-11-29  2:08 ` Nick Roberts
2006-11-29  2:55   ` Daniel Jacobowitz
2006-11-29  4:14     ` Nick Roberts
2006-11-29  7:25   ` Vladimir Prus
2006-11-29 13:45     ` Daniel Jacobowitz [this message]
2006-11-29 13:56       ` Vladimir Prus
2006-11-29 20:25       ` Nick Roberts
2006-11-29  9:09 ` Vladimir Prus
  -- strict thread matches above, loose matches on Subject: below --
2006-11-15  2:45 Nick Roberts
2006-11-15  9:22 ` Vladimir Prus
2006-11-14 13:43 Vladimir Prus
2006-11-14 20:47 ` Daniel Jacobowitz
2006-11-15  9:04   ` Vladimir Prus
2006-11-15 16:25     ` Daniel Jacobowitz
2006-11-17  9:23       ` Vladimir Prus
2006-11-17 10:40         ` Mark Kettenis
2006-11-17 10:45           ` Vladimir Prus
2006-11-17 14:22             ` Daniel Jacobowitz
2006-11-17 15:01               ` Vladimir Prus
2006-11-17 17:19                 ` Vladimir Prus
2006-11-17 18:12                   ` Daniel Jacobowitz
2006-11-18  9:48                     ` Vladimir Prus
2006-11-28 17:09                       ` Daniel Jacobowitz
2006-12-04 19:27                         ` Vladimir Prus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061129134447.GA29365@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=ghost@cs.msu.su \
    --cc=nickrob@snap.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox