From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13655 invoked by alias); 28 Nov 2006 19:40:00 -0000 Received: (qmail 13644 invoked by uid 22791); 28 Nov 2006 19:39:59 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate1.de.ibm.com (HELO mtagate1.de.ibm.com) (195.212.29.150) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 28 Nov 2006 19:39:52 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate1.de.ibm.com (8.13.8/8.13.8) with ESMTP id kASJdjuN175788 for ; Tue, 28 Nov 2006 19:39:48 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.6/8.13.6/NCO v8.1.1) with ESMTP id kASJhMW73211476 for ; Tue, 28 Nov 2006 20:43:22 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id kASJdiwR006245 for ; Tue, 28 Nov 2006 20:39:45 +0100 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id kASJdiMQ006242; Tue, 28 Nov 2006 20:39:44 +0100 Message-Id: <200611281939.kASJdiMQ006242@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 28 Nov 2006 20:39:44 +0100 Subject: Re: [RFA] Remove REALTIME_HI/LO macros from target headers To: drow@false.org (Daniel Jacobowitz) Date: Tue, 28 Nov 2006 19:40:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20061128185608.GA27151@nevyn.them.org> from "Daniel Jacobowitz" at Nov 28, 2006 01:56:08 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00344.txt.bz2 Daniel Jacobowitz wrote: > I'm not too worried about it. Let's assume it won't be a problem, and > if it is, it's easy to fix. OK, fine with me. > > Would it be OK to commit the current patch as-is, and do the removal > > from nm-linux.h as a follow-on patch? > > Yes, that's fine; the current patch is OK. Thanks; I've committed the patch now. Here's the follow-on patch to remove the definition from nm-linux.h as well; tested on s390-ibm-linux and s390x-ibm-linux. OK? Bye, Ulrich ChangeLog: * config/nm-linux.h: Do not include . (REALTIME_LO, REALTIME_HI): Do not define. * signals/signals.c (REALTIME_HI): Fix off-by-one bug. diff -ur gdb-orig/gdb/config/nm-linux.h gdb-head/gdb/config/nm-linux.h --- gdb-orig/gdb/config/nm-linux.h 2006-11-24 19:29:57.000000000 +0100 +++ gdb-head/gdb/config/nm-linux.h 2006-11-28 20:02:26.533200576 +0100 @@ -25,16 +25,6 @@ /* GNU/Linux is SVR4-ish but its /proc file system isn't. */ #undef USE_PROC_FS -/* Since we're building a native debugger, we can include - to find the range of real-time signals. */ - -#include - -#ifdef __SIGRTMIN -#define REALTIME_LO __SIGRTMIN -#define REALTIME_HI (__SIGRTMAX + 1) -#endif - extern void lin_lwp_attach_lwp (ptid_t ptid, int verbose); #define ATTACH_LWP(ptid, verbose) lin_lwp_attach_lwp ((ptid), (verbose)) diff -ur gdb-orig/gdb/signals/signals.c gdb-head/gdb/signals/signals.c --- gdb-orig/gdb/signals/signals.c 2005-12-23 20:05:48.000000000 +0100 +++ gdb-head/gdb/signals/signals.c 2006-11-28 20:02:43.954215168 +0100 @@ -37,10 +37,10 @@ #ifndef REALTIME_LO # if defined(__SIGRTMIN) # define REALTIME_LO __SIGRTMIN -# define REALTIME_HI __SIGRTMAX +# define REALTIME_HI (__SIGRTMAX + 1) # elif defined(SIGRTMIN) # define REALTIME_LO SIGRTMIN -# define REALTIME_HI SIGRTMAX +# define REALTIME_HI (SIGRTMAX + 1) # endif #endif -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com