From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18310 invoked by alias); 28 Nov 2006 18:51:14 -0000 Received: (qmail 18292 invoked by uid 22791); 28 Nov 2006 18:51:13 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.29.155) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 28 Nov 2006 18:51:03 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.8/8.13.8) with ESMTP id kASIox4d185560 for ; Tue, 28 Nov 2006 18:50:59 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.6/8.13.6/NCO v8.1.1) with ESMTP id kASIsalk2810042 for ; Tue, 28 Nov 2006 19:54:36 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id kASIoxFI008680 for ; Tue, 28 Nov 2006 19:50:59 +0100 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id kASIoxaU008674; Tue, 28 Nov 2006 19:50:59 +0100 Message-Id: <200611281850.kASIoxaU008674@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 28 Nov 2006 19:50:59 +0100 Subject: Re: [RFA] Remove REALTIME_HI/LO macros from target headers To: drow@false.org (Daniel Jacobowitz) Date: Tue, 28 Nov 2006 18:51:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20061128152857.GD17349@nevyn.them.org> from "Daniel Jacobowitz" at Nov 28, 2006 10:28:57 AM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00340.txt.bz2 Daniel Jacobowitz wrote: > > For Linux, the nm-linux.h file already defines those macros, so the > > definitions in the tm files appear to be fully redundant. > > The nm-linux.h define is redundant too, isn't it? And off by one? > Compare to the top of signals.c. Or is the copy in signals.c off by > one? Right. The nm-linux.h define should be redundant too. However, it is actually the correct version; the one at the top of signals.c is off by one. (SIGRTMAX is the number of last real-time signal, REALTIME_HI is supposed to be one beyond the number of the last real-time signal.) So we should fix the default definition in signals.c, and then remove the redundant define in nm-linux.h. In fact, this would allow to remove the #include from nm-linux.h as well, but that *might* cause breakage if any of the native Linux targets happens to rely on that implicit inclusion of . That's unfortunately a bit hard to test for ... > Patch looks OK modulo that question. Would it be OK to commit the current patch as-is, and do the removal from nm-linux.h as a follow-on patch? Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com