From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19989 invoked by alias); 28 Nov 2006 17:07:39 -0000 Received: (qmail 6198 invoked by uid 22791); 28 Nov 2006 16:54:40 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 28 Nov 2006 16:54:29 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1Gp6Dy-0005iL-HJ; Tue, 28 Nov 2006 11:54:26 -0500 Date: Tue, 28 Nov 2006 17:07:00 -0000 From: Daniel Jacobowitz To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: Crash in write_exp_msymbol for coff targets. Message-ID: <20061128165426.GA21834@nevyn.them.org> Mail-Followup-To: Pedro Alves , gdb-patches@sourceware.org References: <455CCFAD.6060407@portugalmail.pt> <20061116210236.GA25020@nevyn.them.org> <455CF6BA.2030306@portugalmail.pt> <20061116235909.GA32450@nevyn.them.org> <455D068D.4070507@portugalmail.pt> <455D0CA9.5040901@portugalmail.pt> <20061118235017.GA28256@nevyn.them.org> <455FD80D.4000006@portugalmail.pt> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <455FD80D.4000006@portugalmail.pt> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00320.txt.bz2 On Sun, Nov 19, 2006 at 04:05:33AM +0000, Pedro Alves wrote: > The attached patch does that, and also, I took the opportunity to a > little extra cleanup > on coffread.c by making all minimal symbol creations through > record_minimal_symbol. Looks good to me; I committed it on HEAD. I made only one minor formatting change (struct coff_symbol* cs versus struct coff_symbol *cs). Thanks! -- Daniel Jacobowitz CodeSourcery