From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-46315-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 7941 invoked by alias); 28 Nov 2006 16:56:31 -0000
Received: (qmail 733 invoked by uid 22791); 28 Nov 2006 16:48:26 -0000
X-Spam-Check-By: sourceware.org
Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17)     by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 28 Nov 2006 16:48:00 +0000
Received: from drow by nevyn.them.org with local (Exim 4.63) 	(envelope-from <drow@nevyn.them.org>) 	id 1Gp67i-0005fP-5Q; Tue, 28 Nov 2006 11:47:58 -0500
Date: Tue, 28 Nov 2006 16:56:00 -0000
From: Daniel Jacobowitz <drow@false.org>
To: Nick Clifton <nickc@redhat.com>
Cc: gdb-patches@sourceware.org, kevinb@redhat.com
Subject: Re: RFA: Fix compile time warnings building iq2000-tdep.c
Message-ID: <20061128164758.GC20882@nevyn.them.org>
Mail-Followup-To: Nick Clifton <nickc@redhat.com>, 	gdb-patches@sourceware.org, kevinb@redhat.com
References: <m3r6vnfrnh.fsf@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m3r6vnfrnh.fsf@redhat.com>
User-Agent: Mutt/1.5.13 (2006-08-11)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2006-11/txt/msg00319.txt.bz2

On Tue, Nov 28, 2006 at 04:43:46PM +0000, Nick Clifton wrote:
> Hi Guys,
> 
>   The iq2000 port of GDB currently fails to build on the 6.6 branch
>   and mainline because of compile time warnings triggered in
>   iq2000-tdep.c, (which are now being treated as errors).  The
>   patch below fixes them by changing various void* variables into
>   gdb_byte*.
> 
>   May I apply the patch please ? 

Looks OK except...

> *************** iq2000_extract_return_value (struct type
> *** 558,564 ****
>        returned in a register, and if larger than 8 bytes, it is 
>        returned in a stack location which is pointed to by the same
>        register.  */
> !   CORE_ADDR return_buffer;
>     int len = TYPE_LENGTH (type);
>   
>     if (len <= (2 * 4))
> --- 558,564 ----
>        returned in a register, and if larger than 8 bytes, it is 
>        returned in a stack location which is pointed to by the same
>        register.  */
> !   gdb_byte return_buffer;
>     int len = TYPE_LENGTH (type);
>   
>     if (len <= (2 * 4))

That?  Aren't you going to run off the end of that if it's only a
single byte?

-- 
Daniel Jacobowitz
CodeSourcery