From: Daniel Jacobowitz <drow@false.org>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Remove REALTIME_HI/LO macros from target headers
Date: Tue, 28 Nov 2006 15:29:00 -0000 [thread overview]
Message-ID: <20061128152857.GD17349@nevyn.them.org> (raw)
In-Reply-To: <200611242113.kAOLDMdQ032123@d12av02.megacenter.de.ibm.com>
On Fri, Nov 24, 2006 at 10:13:22PM +0100, Ulrich Weigand wrote:
> However, since signals.c appears to be used only in native configurations,
> that doesn't actually matter. On the other hand, this means we can get
> those defines out of the tm-*.h files and into the nm-*.h files.
Well, those two routines anyway - some of the others are used in common
code.
> The following files currently define the REALTIME macros:
> - config/tm-linux.h and config/mips/tm-linux.h
> - config/rs6000/tm-rs6000ly.h
> - config/tm-nto.h
>
> For Linux, the nm-linux.h file already defines those macros, so the
> definitions in the tm files appear to be fully redundant.
The nm-linux.h define is redundant too, isn't it? And off by one?
Compare to the top of signals.c. Or is the copy in signals.c off by
one?
Patch looks OK modulo that question.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-11-28 15:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-24 21:13 Ulrich Weigand
2006-11-28 15:29 ` Daniel Jacobowitz [this message]
2006-11-28 18:51 ` Ulrich Weigand
2006-11-28 18:56 ` Daniel Jacobowitz
2006-11-28 19:40 ` Ulrich Weigand
2006-11-28 19:41 ` Daniel Jacobowitz
2006-11-28 19:50 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061128152857.GD17349@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox