From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23931 invoked by alias); 24 Nov 2006 02:08:55 -0000 Received: (qmail 23920 invoked by uid 22791); 24 Nov 2006 02:08:54 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 24 Nov 2006 02:08:47 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1GnQUY-00070B-4f; Thu, 23 Nov 2006 21:08:38 -0500 Date: Fri, 24 Nov 2006 02:08:00 -0000 From: Daniel Jacobowitz To: Mark Kettenis Cc: Ulrich Weigand , gdb-patches@sourceware.org Subject: Re: [RFA][2/5] New port: Cell BE SPU (valops.c fix) Message-ID: <20061124020838.GA26661@nevyn.them.org> Mail-Followup-To: Mark Kettenis , Ulrich Weigand , gdb-patches@sourceware.org References: <200611231755.kANHt6g2013138@d12av02.megacenter.de.ibm.com> <5032.82.92.89.47.1164311948.squirrel@webmail.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5032.82.92.89.47.1164311948.squirrel@webmail.xs4all.nl> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00282.txt.bz2 On Thu, Nov 23, 2006 at 08:59:08PM +0100, Mark Kettenis wrote: > I actually think the problem is that you're thinking that s.x lives in > a register where it is actually s itself that lives in that register. > So VALUE_TO_REGISTER should be called for the struct itself, not its > char member. This is at least the second time recently I've seen someone want to go from value to parent value... I'm a little worried about consistency between the two (e.g. do you update value_contents of one? both?) but it may be that we need to link them to do this right. Or, just not use lval_register for struct members / array subscripting. Which may be the same thing in the end? -- Daniel Jacobowitz CodeSourcery