From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10727 invoked by alias); 22 Nov 2006 20:32:39 -0000 Received: (qmail 10719 invoked by uid 22791); 22 Nov 2006 20:32:39 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Wed, 22 Nov 2006 20:32:34 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1Gmylk-0003uE-7O for gdb-patches@sourceware.org; Wed, 22 Nov 2006 15:32:32 -0500 Date: Wed, 22 Nov 2006 20:32:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: Re: [rfc] Do not make up line information Message-ID: <20061122203232.GB14849@nevyn.them.org> Mail-Followup-To: gdb-patches@sourceware.org References: <20061122154249.GA3884@nevyn.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00268.txt.bz2 On Wed, Nov 22, 2006 at 11:54:13AM -0800, Jim Blandy wrote: > Wow --- that's weird code. Where did that alt->line - 1 come from? > > If we can't find the original motivation, the change looks like an > obvious improvement to me. It predates all our changelogs. I imagine it predates debug info for inlining, and DWARF-2, too. -- Daniel Jacobowitz CodeSourcery