From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15143 invoked by alias); 22 Nov 2006 17:22:05 -0000 Received: (qmail 15127 invoked by uid 22791); 22 Nov 2006 17:22:03 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.29.155) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 22 Nov 2006 17:21:54 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.8/8.13.8) with ESMTP id kAMHLpPS236392 for ; Wed, 22 Nov 2006 17:21:51 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.6/8.13.6/NCO v8.1.1) with ESMTP id kAMHPKdT1654878 for ; Wed, 22 Nov 2006 18:25:20 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id kAMHLpxV001134 for ; Wed, 22 Nov 2006 18:21:51 +0100 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id kAMHLpxk001131; Wed, 22 Nov 2006 18:21:51 +0100 Message-Id: <200611221721.kAMHLpxk001131@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 22 Nov 2006 18:21:51 +0100 Subject: Re: [RFA][5/5] New port: Cell BE SPU (testsuite tweaks) To: drow@false.org (Daniel Jacobowitz) Date: Wed, 22 Nov 2006 17:22:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20061122161150.GA5324@nevyn.them.org> from "Daniel Jacobowitz" at Nov 22, 2006 11:11:50 AM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00256.txt.bz2 Daniel Jacobowitz wrote: > Could you check both is_remote and isnative, please? The tests don't > work with remote targets (because they send "run -nw" directly to GDB). > They could be made to, but only if not noargs, and noargs is currently > set for gdbserver so there's not much point. OK, I see. > Patch is OK with that change. I've committed the following patch. Many thanks for reviewing! Bye, Ulrich ChangeLog: * gdb.asm/asm-source.exp: Add "spu*-*-*" target. * gdb.asm/spu.inc: New file. * gdb.base/term.exp: Disable if [target_info exists noargs]. * gdb.gdb/complaints.exp: Disable if ![isnative]. * gdb.gdb/selftest.exp: Likewise. * gdb.gdb/observer.exp: Likewise. * gdb.gdb/xfullpath.exp: Likewise. * gdb.base/attach.exp: Disable on SPU target. * gdb.cp/bs145503.exp: Likewise. * gdb.cp/exception.exp: Likewise. * gdb.cp/userdef.exp: Likewise. diff -urN gdb-orig/gdb/testsuite/gdb.asm/asm-source.exp gdb-head/gdb/testsuite/gdb.asm/asm-source.exp --- gdb-orig/gdb/testsuite/gdb.asm/asm-source.exp 2006-11-22 15:37:06.945107824 +0100 +++ gdb-head/gdb/testsuite/gdb.asm/asm-source.exp 2006-11-22 15:34:19.425149536 +0100 @@ -120,6 +120,11 @@ set asm-flags "-xarch=v9 -I${srcdir}/${subdir} -I${objdir}/${subdir}" set debug-flags "-gdwarf-2" } + "spu*-*-*" { + set asm-arch spu + set asm-flags "-I${srcdir}/${subdir} -I${objdir}/${subdir} --no-warn" + set debug-flags "-gdwarf-2" + } "xstormy16-*-*" { set asm-arch xstormy16 set debug-flags "-gdwarf-2" diff -urN gdb-orig/gdb/testsuite/gdb.asm/spu.inc gdb-head/gdb/testsuite/gdb.asm/spu.inc --- gdb-orig/gdb/testsuite/gdb.asm/spu.inc 1970-01-01 01:00:00.000000000 +0100 +++ gdb-head/gdb/testsuite/gdb.asm/spu.inc 2006-11-22 15:34:19.430148776 +0100 @@ -0,0 +1,42 @@ + comment "subroutine prologue" + .macro gdbasm_enter + stqd $lr, 16($sp) + stqd $sp, -32($sp) + ai $sp, $sp, -32 + .endm + + comment "subroutine epilogue" + .macro gdbasm_leave + ai $sp, $sp, 32 + lqd $lr, 16($sp) + bi $lr + .endm + + .macro gdbasm_call subr + brsl $lr, \subr + .endm + + .macro gdbasm_several_nops + nop + nop + nop + nop + .endm + + comment "exit (0)" + .macro gdbasm_exit0 + stop 0x2000 + stop + stop + stop + .endm + + comment "startup" + .macro gdbasm_startup + il $0, 0 + ila $sp, 16368 + stqd $0, 0($sp) + stqd $sp, -32($sp) + ai $sp, $sp, -32 + stqd $0, 16($sp) + .endm diff -urN gdb-orig/gdb/testsuite/gdb.base/attach.exp gdb-head/gdb/testsuite/gdb.base/attach.exp --- gdb-orig/gdb/testsuite/gdb.base/attach.exp 2006-11-22 15:37:06.950107064 +0100 +++ gdb-head/gdb/testsuite/gdb.base/attach.exp 2006-11-22 15:34:19.436147864 +0100 @@ -32,6 +32,11 @@ return 0 } +# On SPU, this test currently fails because "sleep" is not supported. +if { [istarget "spu*-*-*"] } { + return 0 +} + # are we on a target board if [is_remote target] then { return 0 diff -urN gdb-orig/gdb/testsuite/gdb.base/term.exp gdb-head/gdb/testsuite/gdb.base/term.exp --- gdb-orig/gdb/testsuite/gdb.base/term.exp 2006-11-22 15:37:06.955106304 +0100 +++ gdb-head/gdb/testsuite/gdb.base/term.exp 2006-11-22 15:34:19.481141024 +0100 @@ -29,6 +29,11 @@ continue } +if [target_info exists noargs] then { + verbose "Skipping term.exp because of noargs." + return +} + gdb_start # diff -urN gdb-orig/gdb/testsuite/gdb.cp/bs15503.exp gdb-head/gdb/testsuite/gdb.cp/bs15503.exp --- gdb-orig/gdb/testsuite/gdb.cp/bs15503.exp 2006-11-22 15:37:06.959105696 +0100 +++ gdb-head/gdb/testsuite/gdb.cp/bs15503.exp 2006-11-22 15:34:19.487140112 +0100 @@ -24,6 +24,11 @@ if { [skip_cplus_tests] } { continue } +# On SPU this test fails because the executable exceeds local storage size. +if { [istarget "spu*-*-*"] } { + return 0 +} + set testfile "bs15503" set srcfile ${testfile}.cc set binfile ${objdir}/${subdir}/${testfile} diff -urN gdb-orig/gdb/testsuite/gdb.cp/exception.exp gdb-head/gdb/testsuite/gdb.cp/exception.exp --- gdb-orig/gdb/testsuite/gdb.cp/exception.exp 2006-11-22 15:37:06.964104936 +0100 +++ gdb-head/gdb/testsuite/gdb.cp/exception.exp 2006-11-22 15:34:19.492139352 +0100 @@ -44,6 +44,11 @@ if { [skip_cplus_tests] } { continue } +# On SPU this test fails because the executable exceeds local storage size. +if { [istarget "spu*-*-*"] } { + return 0 +} + set testfile "exception" set srcfile ${testfile}.cc set binfile ${objdir}/${subdir}/${testfile} diff -urN gdb-orig/gdb/testsuite/gdb.cp/userdef.exp gdb-head/gdb/testsuite/gdb.cp/userdef.exp --- gdb-orig/gdb/testsuite/gdb.cp/userdef.exp 2006-11-22 15:37:06.968104328 +0100 +++ gdb-head/gdb/testsuite/gdb.cp/userdef.exp 2006-11-22 15:34:19.497138592 +0100 @@ -27,6 +27,11 @@ if { [skip_cplus_tests] } { continue } +# On SPU this test fails because the executable exceeds local storage size. +if { [istarget "spu*-*-*"] } { + return 0 +} + set testfile "userdef" set srcfile ${testfile}.cc set binfile ${objdir}/${subdir}/${testfile} diff -urN gdb-orig/gdb/testsuite/gdb.gdb/complaints.exp gdb-head/gdb/testsuite/gdb.gdb/complaints.exp --- gdb-orig/gdb/testsuite/gdb.gdb/complaints.exp 2006-11-22 15:37:06.974103416 +0100 +++ gdb-head/gdb/testsuite/gdb.gdb/complaints.exp 2006-11-22 17:20:11.012128128 +0100 @@ -27,7 +27,7 @@ set bug_id 0 # are we on a target board -if [is_remote target] { +if { [is_remote target] || ![isnative] } then { return } diff -urN gdb-orig/gdb/testsuite/gdb.gdb/observer.exp gdb-head/gdb/testsuite/gdb.gdb/observer.exp --- gdb-orig/gdb/testsuite/gdb.gdb/observer.exp 2006-11-22 15:37:06.978102808 +0100 +++ gdb-head/gdb/testsuite/gdb.gdb/observer.exp 2006-11-22 17:20:19.306197656 +0100 @@ -25,7 +25,7 @@ set bug_id 0 # are we on a target board -if [is_remote target] { +if { [is_remote target] || ![isnative] } then { return } diff -urN gdb-orig/gdb/testsuite/gdb.gdb/selftest.exp gdb-head/gdb/testsuite/gdb.gdb/selftest.exp --- gdb-orig/gdb/testsuite/gdb.gdb/selftest.exp 2006-11-22 15:37:06.984101896 +0100 +++ gdb-head/gdb/testsuite/gdb.gdb/selftest.exp 2006-11-22 17:12:31.700188384 +0100 @@ -25,7 +25,7 @@ set bug_id 0 # are we on a target board -if [is_remote target] { +if { [is_remote target] || ![isnative] } then { return } diff -urN gdb-orig/gdb/testsuite/gdb.gdb/xfullpath.exp gdb-head/gdb/testsuite/gdb.gdb/xfullpath.exp --- gdb-orig/gdb/testsuite/gdb.gdb/xfullpath.exp 2006-11-22 15:37:06.988101288 +0100 +++ gdb-head/gdb/testsuite/gdb.gdb/xfullpath.exp 2006-11-22 17:20:30.442103656 +0100 @@ -26,7 +26,7 @@ set bug_id 0 # are we on a target board -if [is_remote target] { +if { [is_remote target] || ![isnative] } then { return } -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com