From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4784 invoked by alias); 22 Nov 2006 14:23:08 -0000 Received: (qmail 4773 invoked by uid 22791); 22 Nov 2006 14:23:08 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Wed, 22 Nov 2006 14:23:02 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1Gmt08-0000Ki-9t for gdb-patches@sourceware.org; Wed, 22 Nov 2006 09:23:00 -0500 Date: Wed, 22 Nov 2006 14:23:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: Re: [RFA][2/5] New port: Cell BE SPU (valops.c fix) Message-ID: <20061122142300.GA1120@nevyn.them.org> Mail-Followup-To: gdb-patches@sourceware.org References: <200611111838.kABIcHaZ031319@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200611111838.kABIcHaZ031319@d12av02.megacenter.de.ibm.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00248.txt.bz2 On Sat, Nov 11, 2006 at 07:38:17PM +0100, Ulrich Weigand wrote: > The patch below 'fixes' this for SPU by at least not calling > VALUE_TO_REGISTER for bitfield assignments, but falling back > to the default code. This happens to work for SPU; other > platforms with special conversion needs might need to get a > chance for the back-end to get involved even then. I guess > when this happens we can think of an extended interface that > would pass the bitsize information through to the back-end ... I've got to admit that I don't like it :-( VALUE_TO_REGISTER has only one caller and eight definitions (plus some documentation). It shouldn't be hard to update it. What additional information do you need? Would passing the two values instead of one regnum and one contents do it? -- Daniel Jacobowitz CodeSourcery