From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11725 invoked by alias); 22 Nov 2006 10:44:16 -0000 Received: (qmail 11706 invoked by uid 22791); 22 Nov 2006 10:44:15 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 22 Nov 2006 10:44:07 +0000 Received: (qmail 7593 invoked from network); 22 Nov 2006 10:44:05 -0000 Received: from unknown (HELO ?172.16.64.38?) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 22 Nov 2006 10:44:05 -0000 From: Vladimir Prus To: gdb-patches@sources.redhat.com Subject: Re: Automatically use hardware watchpoints Date: Wed, 22 Nov 2006 10:44:00 -0000 User-Agent: KMail/1.9.1 References: <200611011447.41170.vladimir@codesourcery.com> <20061121222328.GA7268@nevyn.them.org> In-Reply-To: <20061121222328.GA7268@nevyn.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200611221343.54968.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00241.txt.bz2 On Wednesday 22 November 2006 01:23, Daniel Jacobowitz wrote: > I accidentally typed break when I meant hbreak earlier today. This > patch was fortunately applied to that GDB. It made me very happy > to have this just work. > > The patch is OK for HEAD with minor corrections (plus Eli's doc > requests). Afterwards, I think this is NEWS-worthy (again, since > there's a new command); we haven't always done that in the past, > but I think it's a good idea :-) > > On Wed, Nov 01, 2006 at 02:47:40PM +0300, Vladimir Prus wrote: > > + fprintf_filtered (gdb_stdout, > > + _("Note: automatically using hardware breakpoints for read-only > > addresses.\n")); > > Probably want > > ... gdb_stdout, _("\ > Note:..."); I can't find this escape syntax in the C standard. Is this a gnu extension? > > + made in insert_bp_location are preserved. */ > > two spaces after period. > > And that's it :-) Thanks, checked in. - Volodya