From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 930 invoked by alias); 22 Nov 2006 00:06:41 -0000 Received: (qmail 922 invoked by uid 22791); 22 Nov 2006 00:06:40 -0000 X-Spam-Check-By: sourceware.org Received: from nile.gnat.com (HELO nile.gnat.com) (205.232.38.5) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 22 Nov 2006 00:06:33 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-nile.gnat.com (Postfix) with ESMTP id D10EC48CE36; Tue, 21 Nov 2006 19:06:31 -0500 (EST) Received: from nile.gnat.com ([127.0.0.1]) by localhost (nile.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 01632-01-3; Tue, 21 Nov 2006 19:06:31 -0500 (EST) Received: from takamaka.act-europe.fr (unknown [70.71.0.212]) by nile.gnat.com (Postfix) with ESMTP id 8BA9248CCB7; Tue, 21 Nov 2006 19:06:31 -0500 (EST) Received: by takamaka.act-europe.fr (Postfix, from userid 1000) id 42BA934C099; Tue, 21 Nov 2006 16:06:55 -0800 (PST) Date: Wed, 22 Nov 2006 00:06:00 -0000 From: Joel Brobecker To: Pedro Alves , gdb-patches@sourceware.org Subject: Re: Crash in write_exp_msymbol for coff targets. Message-ID: <20061122000655.GA23363@adacore.com> References: <455CCFAD.6060407@portugalmail.pt> <20061118235432.GB28256@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061118235432.GB28256@nevyn.them.org> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00236.txt.bz2 Hello, > > 2006-11-16 Pedro Alves > > > > * parse.c (write_exp_msymbol): Check if SYMBOL_BFD_SECTION (msymbol) > > is NULL > > before dereferencing it. > > While I think we should fix coffread to set this too, meanwhile, let's > avoid the crash. I've checked this in. Careful of wrapping in the > ChangeLog entry; that line was too long. And thanks for the patch! I also checked this patch in the branch. It's obvious enough and avoids a crash. -- Joel