Re: Automatically use hardware watchpoints

Eli Zaretskii
2006-11-09T21:16:03Z

> From: Vladimir Prus <vladimir@codesourcery.com>
> Date: Wed, 08 Nov 2006 21:47:57 +0300
> >
> > This patch makes insert_bp_location automatically decide what breakpoint
> > type should be used if the target provides a memory map.
>
> And here's a version of this patch that actually includes doc changes.

Thanks.

> Index: doc/gdb.texinfo
> ===================================================================
> RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v
> retrieving revision 1.366
> diff -u -r1.366 gdb.texinfo
> --- doc/gdb.texinfo 27 Oct 2006 22:23:20 -0000 1.366
> +++ doc/gdb.texinfo 1 Nov 2006 11:13:05 -0000

This part is approved, but please take care of the following gotchas:

> +breakpoint address is read-only or read-write. This applies to
^^
Two spaces between sentences, please.

> +breakpoints set with the ``break'' command as well as to internal
> +breakpoints set by commands like ``next'' and ``finish''. For
> +breakpoints set with ``hbreak'', @value{GDBN} will always use hardware
> +breakpoints.

Please use @code{break}, @code{next} etc. for command names.

> +This automatic behaviour can be controlled with the following commands::

Passive voice alarm goes off! How about rewording this as follows:

You can control this automatic behaviour with the following