From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15818 invoked by alias); 21 Nov 2006 22:23:39 -0000 Received: (qmail 15809 invoked by uid 22791); 21 Nov 2006 22:23:37 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 21 Nov 2006 22:23:32 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1Gme1Y-000284-9o; Tue, 21 Nov 2006 17:23:28 -0500 Date: Tue, 21 Nov 2006 22:23:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: Automatically use hardware watchpoints Message-ID: <20061121222328.GA7268@nevyn.them.org> Mail-Followup-To: Vladimir Prus , gdb-patches@sources.redhat.com References: <200611011447.41170.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200611011447.41170.vladimir@codesourcery.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00235.txt.bz2 I accidentally typed break when I meant hbreak earlier today. This patch was fortunately applied to that GDB. It made me very happy to have this just work. The patch is OK for HEAD with minor corrections (plus Eli's doc requests). Afterwards, I think this is NEWS-worthy (again, since there's a new command); we haven't always done that in the past, but I think it's a good idea :-) On Wed, Nov 01, 2006 at 02:47:40PM +0300, Vladimir Prus wrote: > + fprintf_filtered (gdb_stdout, > + _("Note: automatically using hardware breakpoints for read-only addresses.\n")); Probably want ... gdb_stdout, _("\ Note:..."); > + made in insert_bp_location are preserved. */ two spaces after period. And that's it :-) -- Daniel Jacobowitz CodeSourcery