From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8421 invoked by alias); 17 Nov 2006 14:22:46 -0000 Received: (qmail 8412 invoked by uid 22791); 17 Nov 2006 14:22:45 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 17 Nov 2006 14:22:34 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1Gl4bu-0007e4-CU; Fri, 17 Nov 2006 09:22:30 -0500 Date: Fri, 17 Nov 2006 14:22:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: Mark Kettenis , gdb-patches@sources.redhat.com Subject: Re: Variable objects laziness Message-ID: <20061117142230.GA29258@nevyn.them.org> Mail-Followup-To: Vladimir Prus , Mark Kettenis , gdb-patches@sources.redhat.com References: <200611141643.25053.vladimir@codesourcery.com> <20275.192.87.1.22.1163760030.squirrel@webmail.xs4all.nl> <200611171344.54155.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200611171344.54155.vladimir@codesourcery.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00165.txt.bz2 On Fri, Nov 17, 2006 at 01:44:53PM +0300, Vladimir Prus wrote: > On Friday 17 November 2006 13:40, Mark Kettenis wrote: > > > Daniel Jacobowitz wrote: > > > > Sorry, you're right! > > > > > > > > When you're ready, please repost. Might want to finish talking with > > > > Nick first. > > > > As Nick indicated, I'm not sure whether the removal of my_value_equal is > > ok. The whole point of my_value_equal is to check equality of values > > without error()ing out if we can't read a value. Your replacement code > > doesn't seem to take that possibility into account. > > Are you sure? The code has exactly one place where value is fetched, and it > does that by the call to gdb_value_fetch_lazy -- that calls value_fetch_lazy > in a try block. Any errors will be caught and cause the value to be set to > NULL. I think this is the key bit - my_value_equal called value_fetch_lazy, the new code calls gdb_value_fetch_lazy. Vlad, I noticed that the old code used coerce_array and the new one doesn't. Is that a problem? -- Daniel Jacobowitz CodeSourcery