From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3403 invoked by alias); 17 Nov 2006 10:45:16 -0000 Received: (qmail 3391 invoked by uid 22791); 17 Nov 2006 10:45:15 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 17 Nov 2006 10:45:07 +0000 Received: (qmail 26382 invoked from network); 17 Nov 2006 10:45:06 -0000 Received: from unknown (HELO ?172.16.64.38?) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 17 Nov 2006 10:45:06 -0000 From: Vladimir Prus To: "Mark Kettenis" Subject: Re: Variable objects laziness Date: Fri, 17 Nov 2006 10:45:00 -0000 User-Agent: KMail/1.9.1 Cc: gdb-patches@sources.redhat.com References: <200611141643.25053.vladimir@codesourcery.com> <20275.192.87.1.22.1163760030.squirrel@webmail.xs4all.nl> In-Reply-To: <20275.192.87.1.22.1163760030.squirrel@webmail.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200611171344.54155.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00164.txt.bz2 On Friday 17 November 2006 13:40, Mark Kettenis wrote: > > Daniel Jacobowitz wrote: > > > Sorry, you're right! > > > > > > When you're ready, please repost. Might want to finish talking with > > > Nick first. > > As Nick indicated, I'm not sure whether the removal of my_value_equal is > ok. The whole point of my_value_equal is to check equality of values > without error()ing out if we can't read a value. Your replacement code > doesn't seem to take that possibility into account. Are you sure? The code has exactly one place where value is fetched, and it does that by the call to gdb_value_fetch_lazy -- that calls value_fetch_lazy in a try block. Any errors will be caught and cause the value to be set to NULL. > Or is it that your new > code no longer needs to do this comparison? If that's the case, do > watchpoints still work? Sorry, what watchpoint have to do with this? my_value_equal is not used to implement watchpoints -- only var-update and -var-assign. - Volodya