From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20499 invoked by alias); 15 Nov 2006 21:57:18 -0000 Received: (qmail 20393 invoked by uid 22791); 15 Nov 2006 21:57:16 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.29.155) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 15 Nov 2006 21:57:08 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.8/8.13.8) with ESMTP id kAFLv4jW384066 for ; Wed, 15 Nov 2006 21:57:04 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.6/8.13.6/NCO v8.1.1) with ESMTP id kAFM0L3x3289120 for ; Wed, 15 Nov 2006 23:00:21 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id kAFLv45L003610 for ; Wed, 15 Nov 2006 22:57:04 +0100 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id kAFLv4Ab003607; Wed, 15 Nov 2006 22:57:04 +0100 Message-Id: <200611152157.kAFLv4Ab003607@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 15 Nov 2006 22:57:04 +0100 Subject: Re: [RFA][1/5] New port: Cell BE SPU (dwarf2loc.c fix) To: jimb@codesourcery.com (Jim Blandy) Date: Wed, 15 Nov 2006 21:57:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: from "Jim Blandy" at Nov 13, 2006 11:40:22 AM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00134.txt.bz2 Jim Blandy wrote: > This seems fine. I tested it on i686 Fedora Core 5 and didn't see any > new failures. > > Would it be a good idea to introduce a new function, a companion to > value_from_register, that wraps up the composition of > value_from_register and value_as_address? You mean something like the patch below? Tested on spu, s390-ibm-linux and s390x-ibm-linux. Bye, Ulrich ChangeLog: * findvar.c (address_from_register): New function. * value.h (address_from_register): Add prototype. * dwarf2loc.c (dwarf_expr_read_reg): Use address_from_register. diff -ur gdb-orig/gdb/dwarf2loc.c gdb-head/gdb/dwarf2loc.c --- gdb-orig/gdb/dwarf2loc.c 2006-11-10 03:00:22.000000000 +0100 +++ gdb-head/gdb/dwarf2loc.c 2006-11-15 22:12:11.624037552 +0100 @@ -115,24 +115,17 @@ /* Helper functions for dwarf2_evaluate_loc_desc. */ /* Using the frame specified in BATON, return the value of register - REGNUM, treated as an unsigned integer. */ + REGNUM, treated as a pointer. */ static CORE_ADDR dwarf_expr_read_reg (void *baton, int dwarf_regnum) { struct dwarf_expr_baton *debaton = (struct dwarf_expr_baton *) baton; CORE_ADDR result; - gdb_byte *buf; - int regnum, regsize; + int regnum; regnum = DWARF2_REG_TO_REGNUM (dwarf_regnum); - regsize = register_size (current_gdbarch, regnum); - buf = alloca (regsize); - - frame_register_read (debaton->frame, regnum, buf); - /* NOTE: cagney/2003-05-22: This extract is assuming that a DWARF 2 - address is always unsigned. That may or may not be true. */ - result = extract_unsigned_integer (buf, regsize); - + result = address_from_register (builtin_type_void_data_ptr, + regnum, debaton->frame); return result; } diff -ur gdb-orig/gdb/findvar.c gdb-head/gdb/findvar.c --- gdb-orig/gdb/findvar.c 2006-01-17 23:30:29.000000000 +0100 +++ gdb-head/gdb/findvar.c 2006-11-15 22:09:11.884934888 +0100 @@ -728,6 +728,26 @@ return v; } +/* Return contents of register REGNUM in frame FRAME as address, + interpreted as value of type TYPE. Will abort if register + value is not available. */ + +CORE_ADDR +address_from_register (struct type *type, int regnum, struct frame_info *frame) +{ + struct value *value; + CORE_ADDR result; + + value = value_from_register (type, regnum, frame); + gdb_assert (value); + + result = value_as_address (value); + release_value (value); + value_free (value); + + return result; +} + /* Given a struct symbol for a variable or function, and a stack frame id, diff -ur gdb-orig/gdb/value.h gdb-head/gdb/value.h --- gdb-orig/gdb/value.h 2006-07-13 06:31:42.000000000 +0200 +++ gdb-head/gdb/value.h 2006-11-15 22:10:31.813034144 +0100 @@ -282,6 +282,9 @@ extern struct value *value_from_register (struct type *type, int regnum, struct frame_info *frame); +extern CORE_ADDR address_from_register (struct type *type, int regnum, + struct frame_info *frame); + extern struct value *value_of_variable (struct symbol *var, struct block *b); extern struct value *value_of_register (int regnum, struct frame_info *frame); -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com