From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 418 invoked by alias); 11 Nov 2006 01:40:38 -0000 Received: (qmail 407 invoked by uid 22791); 11 Nov 2006 01:40:37 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Sat, 11 Nov 2006 01:40:29 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1Gihr8-00049D-HI; Fri, 10 Nov 2006 20:40:26 -0500 Date: Sat, 11 Nov 2006 01:40:00 -0000 From: Daniel Jacobowitz To: Maxim Grigoriev Cc: gdb-patches@sources.redhat.com, Bob Wilson , Marc Gauthier , Chris Zankel Subject: Re: Xtensa GDB port -- revised patch Message-ID: <20061111014026.GA15921@nevyn.them.org> Mail-Followup-To: Maxim Grigoriev , gdb-patches@sources.redhat.com, Bob Wilson , Marc Gauthier , Chris Zankel References: <451B202C.3090804@hq.tensilica.com> <20060928011910.GA20142@nevyn.them.org> <45259B4B.3010101@hq.tensilica.com> <20061110203908.GC1115@nevyn.them.org> <45552583.8070206@hq.tensilica.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45552583.8070206@hq.tensilica.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00078.txt.bz2 On Fri, Nov 10, 2006 at 05:21:07PM -0800, Maxim Grigoriev wrote: > I understood your concern is that the register number within the next > frame is not set ( *realnump ). On Xtensa, it's going to be unchanged > from the previous frame's value. > > Question: is replacing of > > frame_register_unwind (next_frame, regnum, > optimizedp, lvalp, addrp, realnump, valuep); > > with > > *optimizedp = 0; > *lvalp = lval_register; > *addrp = 0; > *realnump = regnum; > if (valuep) > frame_unwind_register (next_frame, (*realnump), valuep); > > the fix you are looking for ? I tested it. It works fine. Yes, I think that's right. -- Daniel Jacobowitz CodeSourcery