From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30357 invoked by alias); 10 Nov 2006 20:20:26 -0000 Received: (qmail 30348 invoked by uid 22791); 10 Nov 2006 20:20:26 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 10 Nov 2006 20:20:20 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1GicrH-0001GY-UB; Fri, 10 Nov 2006 15:20:16 -0500 Date: Fri, 10 Nov 2006 20:20:00 -0000 From: Daniel Jacobowitz To: Denis PILAT , bash-maintainers@gnu.org Cc: gdb-patches Subject: Re: [readline] TUI size computation for mingw32 hosts Message-ID: <20061110202015.GB1115@nevyn.them.org> Mail-Followup-To: Denis PILAT , bash-maintainers@gnu.org, gdb-patches References: <451BCA71.5040109@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <451BCA71.5040109@st.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00070.txt.bz2 Hi Chet, Not sure if you ever saw the attached message. Could you let me know if this fix is OK for readline, so that I can update GDB's bundled copy? Thanks in advance. On Thu, Sep 28, 2006 at 03:13:21PM +0200, Denis PILAT wrote: > Attached is a patch that fix a problem of calculating console window size > when gdb is hosted on windows. > > I already fixed this problem in gdb 6.4 version, that was integrated into > readline (cf > http://sources.redhat.com/ml/gdb-patches/2006-02/msg00245.html) > , but the readline I got from the 6.5 version cancels the modification > with some new > code that overwrote variables I used. > > > Denis > 2006-09-28 Denis Pilat > > * readline/terminal.c (_rl_get_screen_size): use wr and wc variable to store > window size. > > > Index: terminal.c > =================================================================== > --- terminal.c (revision 527) > +++ terminal.c (working copy) > @@ -226,8 +226,8 @@ _rl_get_screen_size (tty, ignore_env) > CONSOLE_SCREEN_BUFFER_INFO scr; > if (GetConsoleScreenBufferInfo (hConOut, &scr)) > { > - _rl_screenwidth = scr.dwSize.X; > - _rl_screenheight = scr.srWindow.Bottom - scr.srWindow.Top + 1; > + wc = scr.dwSize.X; > + wr = scr.srWindow.Bottom - scr.srWindow.Top + 1; > } > } > #endif -- Daniel Jacobowitz CodeSourcery