From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32024 invoked by alias); 6 Nov 2006 14:33:17 -0000 Received: (qmail 31974 invoked by uid 22791); 6 Nov 2006 14:33:16 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Mon, 06 Nov 2006 14:33:09 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1Gh5X9-0008EK-3a; Mon, 06 Nov 2006 09:33:07 -0500 Date: Mon, 06 Nov 2006 14:33:00 -0000 From: Daniel Jacobowitz To: Jim Blandy Cc: gdb-patches@sourceware.org Subject: Re: PATCH: use frame_unwind_register instead of frame_register Message-ID: <20061106143307.GA31556@nevyn.them.org> Mail-Followup-To: Jim Blandy , gdb-patches@sourceware.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00027.txt.bz2 On Fri, Nov 03, 2006 at 02:11:17PM -0800, Jim Blandy wrote: > > Committed as obvious --- frame_unwind_register takes care of passing > all the dummy arguments to frame_register, so dwarf_expr_read_reg > shouldn't have to bother. > > gdb/ChangeLog: > 2006-11-03 Jim Blandy > > * dwarf2loc.c (dwarf_expr_read_reg): Use frame_unwind_register > instead of frame_register. Doc fix. Jim, in addition to leaving a pile of unused variables in the function (see my other message from Friday), you've introduced an off-by-one-frame error here. frame_register unwinds from the NEXT frame, but frame_unwind_register unwinds from THIS frame. Our GDB autotester reported about six hundred new failures and I'm pretty sure that's why; we now use the previous frame's r11 for fbreg. Could you revert or fix this, please? -- Daniel Jacobowitz CodeSourcery