From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1879 invoked by alias); 20 Oct 2006 18:07:16 -0000 Received: (qmail 1759 invoked by uid 22791); 20 Oct 2006 18:07:16 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 20 Oct 2006 18:07:10 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1Gaylv-0001Ph-UQ; Fri, 20 Oct 2006 14:07:08 -0400 Date: Fri, 20 Oct 2006 18:07:00 -0000 From: Daniel Jacobowitz To: Eli Zaretskii Cc: andrew.stubbs@st.com, gdb-patches@sourceware.org Subject: Re: [PATCH] Don't give spurious warnings when using thread specific breakpoints Message-ID: <20061020180707.GA5398@nevyn.them.org> Mail-Followup-To: Eli Zaretskii , andrew.stubbs@st.com, gdb-patches@sourceware.org References: <45361793.1020202@st.com> <20061018141419.GA7771@nevyn.them.org> <4536444C.9020709@st.com> <45374981.5080304@st.com> <20061020142933.GA28396@nevyn.them.org> <20061020174648.GA4647@nevyn.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-10/txt/msg00258.txt.bz2 On Fri, Oct 20, 2006 at 08:03:41PM +0200, Eli Zaretskii wrote: > How about rewriting the code so it'll produce something like > > Note: breakpoint(s) 1-9, 10-15, 21, 42 also set at pc 0x439ee0. > > ? > > Then we could have the variable list of breakpoint numbers produced > as a string, and output that string with a format such as this: > > "Note: breakpoint(s) %s also set at pc 0x%x." > > Actually, this would work for i18n even if we don't produce ranges of > numbers but a plain "1, 2, 3, 4, ..." list, but ranges would compress > some overly-long lists. > > The `disabled' notification could be printed as a separate message. > For example: > > Note: breakpoint(s) 1-9, 10-15, 21, 42 also set at pc 0x439ee0. > Note: breakpoint(s) 3, 11, 21 are disabled. > > We could do something similar with "(thread %d)", for example produce > a separate message for each thread. I think that the current format > becomes quite unreadable anyway when too many "disabled" and "thread > N" parts are produced. > > WDYT? I think it's pretty clever. I'll keep this solution in mind for the future. (I'm not planning to work on it myself, though - so far, a translated GDB remains a theoretical exercise.) -- Daniel Jacobowitz CodeSourcery