From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20157 invoked by alias); 20 Oct 2006 17:47:00 -0000 Received: (qmail 20149 invoked by uid 22791); 20 Oct 2006 17:46:59 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 20 Oct 2006 17:46:53 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1GaySG-0001Hd-OG; Fri, 20 Oct 2006 13:46:48 -0400 Date: Fri, 20 Oct 2006 17:47:00 -0000 From: Daniel Jacobowitz To: Eli Zaretskii Cc: andrew.stubbs@st.com, gdb-patches@sourceware.org Subject: Re: [PATCH] Don't give spurious warnings when using thread specific breakpoints Message-ID: <20061020174648.GA4647@nevyn.them.org> Mail-Followup-To: Eli Zaretskii , andrew.stubbs@st.com, gdb-patches@sourceware.org References: <452D0385.6010103@st.com> <20061011204525.GA9622@nevyn.them.org> <45361793.1020202@st.com> <20061018141419.GA7771@nevyn.them.org> <4536444C.9020709@st.com> <45374981.5080304@st.com> <20061020142933.GA28396@nevyn.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-10/txt/msg00256.txt.bz2 On Fri, Oct 20, 2006 at 07:38:59PM +0200, Eli Zaretskii wrote: > > (gdb) b main > > Breakpoint 1 at 0x439ee0 > > (gdb) b main > > Note: breakpoint 1 also set at pc 0x439ee0. > > Breakpoint 2 at 0x439ee0 > > (gdb) b main > > Note: breakpoints 1 and 2 also set at pc 0x439ee0. > > Breakpoint 3 at 0x439ee0 > > (gdb) disable 2 > > (gdb) b main > > Note: breakpoints 1, 2 (disabled) and 3 also set at pc 0x439ee0. > > Breakpoint 4 at 0x439ee0 > > We need to have different code branches, one each for each one of the > possibilities, and each branch should have a format string for a full > sentence that is produced by that branch. > > If there are too many such possible combinations, then the i18n > comment should explain the context, as I mentioned elsewhere. (I'm > quite sure we've been through a similar discussion a year or so ago, > about another place where the code does similar things.) And I'm pretty sure we concluded there wasn't a reasonable way to do this... perhaps my example wasn't good enough. Or perhaps I've forgotten the trick to it. (gdb) Note: breakpoints 1, 2, 3, 4, 5, 6, 7 and 8 also set at pc 0x439ee0. Breakpoint 9 at 0x439ee0 (gdb) Note: breakpoints 1, 2, 3, 4, 5, 6, 7, 8 and 9 also set at pc 0x439ee0. Breakpoint 10 at 0x439ee0 (gdb) Note: breakpoints 1, 2, 3, 4, 5, 6, 7, 8, 9 and 10 also set at pc 0x439ee0. Breakpoint 11 at 0x439ee0 There can be an arbitrary number of elements. We build up the list with ", " and ", and ", along with " (disabled)" and " (thread %d)". It'd be easy to reduce the possibilities somewhat, by using "%d (disabled)" and "%d (disabled) (thread %d)" and so forth. But I'm stumped what to do about the comma separated list. -- Daniel Jacobowitz CodeSourcery