From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18810 invoked by alias); 17 Oct 2006 21:57:58 -0000 Received: (qmail 18802 invoked by uid 22791); 17 Oct 2006 21:57:58 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 17 Oct 2006 21:57:55 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1GZwwc-0003xh-7H; Tue, 17 Oct 2006 17:57:54 -0400 Date: Tue, 17 Oct 2006 21:57:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] PR mi/2086 -break-insert missing error diagnostic Message-ID: <20061017215754.GA15210@nevyn.them.org> Mail-Followup-To: Nick Roberts , gdb-patches@sources.redhat.com References: <17717.17922.450312.898237@kahikatea.snap.net.nz> <20061017213119.GA14010@nevyn.them.org> <17717.20397.279496.222573@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17717.20397.279496.222573@kahikatea.snap.net.nz> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-10/txt/msg00199.txt.bz2 On Wed, Oct 18, 2006 at 10:48:29AM +1300, Nick Roberts wrote: > > > This patch fixes PR mi/2086. There may be similar bugs arising from using > > > catch_exceptions_with_msg inappropriately. > > > > Is this the whole patch? I guess you updated the caller too. > > I have other changes but they're all older. I think that's it but I'll > check more carefully. Well, it won't compile as-is, so obviously you haven't tested this patch on its own :-) > > I think removing catch_exceptions_with_msg isn't enough - if you look > > at the call site, it's not prepared for an error() to escape there. > > It would have to use a cleanup for deprecated_set_gdb_event_hooks. > > Heres my take: > > I think the problem arises from changes Andrew Cagney made on 2005-01-13. > It worked before then but was probably a bit of a hack. By removing > catch_exceptions_with_msg the error propagates back to catch_exception > with the function argument captured_mi_execute_command: > > #14 0x0812fdf8 in catch_exception (uiout=0x8823918, func=0x80ca1e7 , func_args=0xbfc229a4, mask=6) at exceptions.c:469 > #15 0x080ca5de in mi_execute_command (cmd=0x8855220 "-break-insert *", from_tty= > > (mi_execute_command was also changed on 2005-01-13). But we've messed up whatever those saved/restored hooks were. -- Daniel Jacobowitz CodeSourcery