From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21268 invoked by alias); 17 Oct 2006 15:53:25 -0000 Received: (qmail 21258 invoked by uid 22791); 17 Oct 2006 15:53:24 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 17 Oct 2006 15:53:14 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1GZrFf-0000LA-10; Tue, 17 Oct 2006 11:53:11 -0400 Date: Tue, 17 Oct 2006 15:53:00 -0000 From: Daniel Jacobowitz To: Michael Snyder , Mark Kettenis , GDB Patches ML Subject: Re: PING Re: [RFC] thread tests, linux/gdbserver Message-ID: <20061017155310.GB30823@nevyn.them.org> Mail-Followup-To: Michael Snyder , Mark Kettenis , GDB Patches ML References: <1159223190.24808.52.camel@localhost.localdomain> <1160084737.9761.89.camel@localhost.localdomain> <20713.192.87.1.22.1160132019.squirrel@webmail.xs4all.nl> <1160159477.9761.124.camel@localhost.localdomain> <20061017154611.GA30823@nevyn.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061017154611.GA30823@nevyn.them.org> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-10/txt/msg00182.txt.bz2 On Tue, Oct 17, 2006 at 11:46:11AM -0400, Daniel Jacobowitz wrote: > It fixes a bunch of failures in linux-dp.exp and thread-specific.exp, > and lets more tests run for pthreads.exp. I noticed that Michael's patch fixed manythreads.exp, but I didn't see that in my changes. So I looked closer: it wasn't being run at all, because it wasn't 64-bit safe, and then it had an additional assumption. I tested and committed the attached obvious fixups. -- Daniel Jacobowitz CodeSourcery 2006-10-17 Daniel Jacobowitz * gdb.threads/manythreads.c (thread_function, main): Don't cast int to pointer or pointer to int. * gdb.threads/manythreads.exp: Don't expect the string "LWP". Index: testsuite/gdb.threads/manythreads.c =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/manythreads.c,v retrieving revision 1.3 diff -u -p -r1.3 manythreads.c --- testsuite/gdb.threads/manythreads.c 23 Apr 2004 19:01:17 -0000 1.3 +++ testsuite/gdb.threads/manythreads.c 17 Oct 2006 15:50:27 -0000 @@ -1,5 +1,5 @@ /* Manythreads test program. - Copyright 2004 + Copyright 2004, 2006 Free Software Foundation, Inc. Written by Jeff Johnston @@ -29,7 +29,7 @@ void * thread_function (void *arg) { - int x = (int)arg; + int x = * (int *) arg; printf ("Thread <%d> executing\n", x); @@ -41,6 +41,7 @@ main (int argc, char **argv) { pthread_attr_t attr; pthread_t threads[256]; + int args[256]; int i, j; pthread_attr_init (&attr); @@ -52,8 +53,8 @@ main (int argc, char **argv) { for (j = 0; j < 256; ++j) { - pthread_create (&threads[j], &attr, thread_function, - (void *)(i * 1000 + j)); + args[j] = i * 1000 + j; + pthread_create (&threads[j], &attr, thread_function, &args[j]); } for (j = 0; j < 256; ++j) Index: testsuite/gdb.threads/manythreads.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/manythreads.exp,v retrieving revision 1.2 diff -u -p -r1.2 manythreads.exp --- testsuite/gdb.threads/manythreads.exp 3 Jun 2004 22:10:56 -0000 1.2 +++ testsuite/gdb.threads/manythreads.exp 17 Oct 2006 15:50:27 -0000 @@ -1,5 +1,5 @@ # manythreads.exp -- Expect script to test stopping many threads -# Copyright (C) 2004 Free Software Foundation, Inc. +# Copyright (C) 2004, 2006 Free Software Foundation, Inc. # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -81,7 +81,7 @@ gdb_test_multiple "" "stop threads 1" { } } -gdb_test "info threads" ".*1 Thread.*.LWP.*" +gdb_test "info threads" ".*1 Thread .*" set message "second continue" gdb_test_multiple "continue" "second continue" {