From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13757 invoked by alias); 13 Oct 2006 13:30:51 -0000 Received: (qmail 13749 invoked by uid 22791); 13 Oct 2006 13:30:51 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 13 Oct 2006 13:30:49 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1GYN7e-0002UK-Ln; Fri, 13 Oct 2006 09:30:46 -0400 Date: Fri, 13 Oct 2006 13:30:00 -0000 From: Daniel Jacobowitz To: Fred Fish Cc: GDB Patches Subject: Re: [RFC] Patch for QUIT macro support Message-ID: <20061013133046.GA9478@nevyn.them.org> Mail-Followup-To: Fred Fish , GDB Patches References: <200610130543.25806.fnf@specifix.com> <200610130622.39164.fnf@specifix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200610130622.39164.fnf@specifix.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-10/txt/msg00150.txt.bz2 On Fri, Oct 13, 2006 at 06:22:39AM -0700, Fred Fish wrote: > On Friday 13 October 2006 05:43, Fred Fish wrote: > > To test a possible fix for this, I made the following change: > > OK, guess I should keep up with the gdb-patches list more, particularly > before posting. :-) > > I see Nick Roberts just posted a patch a few hours earlier that > addresses the issue of where quit_flag is set. It also occured to > me after posting my quick and dirty patch that it probably wasn't > necessary to jump all the way back into the event loop signal > handling code, just simply continue to check for the quit_flag > and call quit when it's set. Do you mean the big async patch? If so it's still worth fixing this in isolation. Otherwise, I must have missed a patch. I may not have time to look at this for a while - I find the event loop so confusing - but in the meantime, it's come up before: http://sourceware.org/ml/gdb-patches/2003-08/msg00213.html http://sourceware.org/ml/gdb-patches/2004-02/msg00530.html http://sourceware.org/ml/gdb-patches/2004-05/msg00234.html Maybe one of those threads will be enlightening on how it's "supposed" to work. -- Daniel Jacobowitz CodeSourcery